From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Doug Evans <dje@google.com>, qemu-devel@nongnu.org
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing
Date: Mon, 8 Feb 2021 12:09:02 +0100 [thread overview]
Message-ID: <fc97283f-51ca-2a2d-d8ae-1345b990e52c@redhat.com> (raw)
In-Reply-To: <20210203213729.1940893-2-dje@google.com>
Hi Doug,
On 2/3/21 10:37 PM, dje--- via wrote:
> ... in preparation for adding ipv6 host forwarding support.
Please duplicate subject line, else this commit description as it
doesn't make sense.
> ---
> net/slirp.c | 200 +++++++++++++++++++++++++++++++++-------------------
> slirp | 2 +-
> 2 files changed, 130 insertions(+), 72 deletions(-)
>
...
> diff --git a/slirp b/slirp
> index 8f43a99191..358c0827d4 160000
> --- a/slirp
> +++ b/slirp
> @@ -1 +1 @@
> -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece
> +Subproject commit 358c0827d49778f016312bfb4167fe639900681f
>
When updating submodules, please describe changes (usually -
when possible - a previous commit updating the submodule is
preferred).
I can not apply your patch using either
https://git.qemu.org/git/libslirp.git or
https://gitlab.freedesktop.org/slirp/libslirp.git:
fatal: bad object 358c0827d49778f016312bfb4167fe639900681f
next prev parent reply other threads:[~2021-02-08 17:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 21:37 [PATCH v2 0/2] Add support for ipv6 host forwarding dje--- via
2021-02-03 21:37 ` [PATCH v2 1/2] net/slirp.c: Refactor address parsing dje--- via
2021-02-03 21:39 ` Doug Evans
2021-02-03 22:15 ` Samuel Thibault
2021-02-03 22:31 ` Doug Evans
2021-02-08 11:09 ` Philippe Mathieu-Daudé [this message]
2021-02-08 18:59 ` Doug Evans
2021-02-28 22:44 ` Samuel Thibault
2021-02-03 21:37 ` [PATCH v2 2/2] net: Add -ipv6-hostfwd option, ipv6_hostfwd_add/remove commands dje--- via
2021-02-03 22:20 ` Samuel Thibault
2021-02-03 22:29 ` Doug Evans
2021-02-04 9:57 ` Daniel P. Berrangé
2021-02-03 21:45 ` [PATCH v2 0/2] Add support for ipv6 host forwarding no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc97283f-51ca-2a2d-d8ae-1345b990e52c@redhat.com \
--to=philmd@redhat.com \
--cc=dje@google.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).