qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Artyom Kunakovsky <artyomkunakovsky@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] meson.build: add -mcx16 flag
Date: Thu, 23 May 2024 12:12:48 +0200	[thread overview]
Message-ID: <fc9c7a1e-2d25-4580-90c7-98578e8fbd9a@redhat.com> (raw)
In-Reply-To: <20240522193016.136866-1-artyomkunakovsky@gmail.com>

On 5/22/24 21:30, Artyom Kunakovsky wrote:
> fix linker error if the project was configured by the './configure --cpu=unknown --target-list=riscv64-softmmu' command
> 
> Signed-off-by: Artyom Kunakovsky <artyomkunakovsky@gmail.com>
> ---
>   meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index a9de71d450..0c24878c86 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -298,7 +298,7 @@ endforeach
>   
>   qemu_common_flags = [
>     '-D_GNU_SOURCE', '-D_FILE_OFFSET_BITS=64', '-D_LARGEFILE_SOURCE',
> -  '-fno-strict-aliasing', '-fno-common', '-fwrapv' ]
> +  '-fno-strict-aliasing', '-fno-common', '-fwrapv', '-mcx16' ]

-mcx16 does not exist on non-x86 hosts so this change breaks them.

QEMU's configure script knows to add -mcx16 on x86 hosts; you've added 
--cpu=unknown yourself, you have to add --extra-cflags=-mcx16 as well.

Paolo

>   qemu_cflags = []
>   qemu_ldflags = []
>   



      parent reply	other threads:[~2024-05-23 10:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 19:30 [PATCH] meson.build: add -mcx16 flag Artyom Kunakovsky
2024-05-23  8:02 ` Daniel P. Berrangé
2024-05-23  8:35   ` Artyom Kunakovsky
2024-05-23  8:52   ` Peter Maydell
2024-05-23  9:14     ` Daniel P. Berrangé
2024-05-23 10:12 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc9c7a1e-2d25-4580-90c7-98578e8fbd9a@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=artyomkunakovsky@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).