From: Max Reitz <mreitz@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Cc: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 4/6] iotests: Check for the availability of the required devices in 267 and 127
Date: Mon, 20 Jan 2020 15:47:54 +0100 [thread overview]
Message-ID: <fca7c2d0-c4d9-e607-4b20-93cf10b1ea38@redhat.com> (raw)
In-Reply-To: <20191202101039.8981-5-thuth@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 822 bytes --]
On 02.12.19 11:10, Thomas Huth wrote:
> We are going to enable 127 in the "auto" group, but it only works if
> virtio-scsi and scsi-hd are available - which is not the case with
> QEMU binaries like qemu-system-tricore for example, so we need a
> proper check for the availability of these devices here.
>
> A very similar problem exists in iotest 267 - it has been added to
> the "auto" group already, but requires virtio-blk and thus currently
> fails with qemu-system-tricore for example. Let's also add aproper
> check there.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/127 | 2 ++
> tests/qemu-iotests/267 | 2 ++
> tests/qemu-iotests/common.rc | 14 ++++++++++++++
> 3 files changed, 18 insertions(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-01-20 14:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 10:10 [PATCH v4 0/6] Enable more iotests during "make check-block" Thomas Huth
2019-12-02 10:10 ` [PATCH v4 1/6] iotests: remove 'linux' from default supported platforms Thomas Huth
2019-12-02 10:10 ` [PATCH v4 2/6] iotests: Test 041 only works on certain systems Thomas Huth
2020-01-20 14:31 ` Max Reitz
2019-12-02 10:10 ` [PATCH v4 3/6] iotests: Test 183 does not work on macOS and OpenBSD Thomas Huth
2020-01-20 14:36 ` Max Reitz
2020-01-20 16:01 ` Thomas Huth
2019-12-02 10:10 ` [PATCH v4 4/6] iotests: Check for the availability of the required devices in 267 and 127 Thomas Huth
2020-01-20 14:47 ` Max Reitz [this message]
2019-12-02 10:10 ` [PATCH v4 5/6] iotests: Skip Python-based tests if QEMU does not support virtio-blk Thomas Huth
2020-01-20 14:50 ` Max Reitz
2020-01-20 16:05 ` Thomas Huth
2019-12-02 10:10 ` [PATCH v4 6/6] iotests: Enable more tests in the 'auto' group to improve test coverage Thomas Huth
2020-01-20 14:51 ` Max Reitz
2020-01-20 14:52 ` [PATCH v4 0/6] Enable more iotests during "make check-block" Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fca7c2d0-c4d9-e607-4b20-93cf10b1ea38@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).