From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7000BC07CA9 for ; Thu, 30 Nov 2023 13:51:17 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r8hQj-0006dD-8Q; Thu, 30 Nov 2023 08:50:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r8hQV-0006V3-AK for qemu-devel@nongnu.org; Thu, 30 Nov 2023 08:50:02 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r8hQT-0001Ig-BV for qemu-devel@nongnu.org; Thu, 30 Nov 2023 08:49:59 -0500 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40b54261442so7822535e9.1 for ; Thu, 30 Nov 2023 05:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701352196; x=1701956996; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MzXC86kI/230MRmOExolGBgQpce+zyW7qougvXLVSk8=; b=I25aAQN3MwjonWQAuXfFk0f4HfMOhFTw+vwYH+7LaxUmESp8giU/JcRynvg2cOAK4O FWD7RjbjDPJuNzJfgD7AF3l+TAvHpfAzRpkxijP8NhSPqx7FXKVi3Rj5AUl8Mk2PgEo8 lu2As9DQDyDTONl/qwdnbfLGqFeVoG53EFquA9ex65zkrLcjzCh39o5L+pp2UOKaEYp/ xeutKbblANB4GiSU+yBeHo/Aoe3bBh3FGOfj98GwJsNf59xTu7vBpChQhj46TdzWj+Am It6Fb0V2KAMeHpMqxtEVVc9D+Au5qphui+PQBerUAapilUICqP8bHOFpv32vUrrX8zwk kK1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701352196; x=1701956996; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MzXC86kI/230MRmOExolGBgQpce+zyW7qougvXLVSk8=; b=tfksNp7ATF3SnAsee1MuvraGeNO484uXKu9c3HggtTkx0H9ZojjkaMjsP6ZNWopVTh x7gLvQl+BLFAGM8YOVK5JIUfUwaaXaNKzKtFLOFYpadhey/J02mkMSWAKDWOP7/JNzgh oYAV6UsOwrm+W3aaLUaOMU5fFz3htnJcY4M/MDhp8YWMyNiP6T9klTi8CKtz6LLn9sZt zN8impCE9F3dTv97SCyKsqNuUm2/PZc3UbgF2rbzd6+WCOyuMZlE7ZnhKYTko2BWJu7t g5UhLIocu0YAE26osFgrhRmZN65AKfo/mDoETirG0uDeRp61HK30P7e05ZR5dMM1VFiX UYFA== X-Gm-Message-State: AOJu0Yz4J5R/DEjL43euhpJQXm88Kh0AqX8oeHubTlagZH3Gb+7CLPrC UjEg3yZUH7ufI9CsqROw7KdmyA== X-Google-Smtp-Source: AGHT+IGEZM/F60lbKf+pyOaxLGJZDqngSEf0GXts+oJS0AF+AGOPuKqrMqfmt5a2LHBk+wqKglvvAA== X-Received: by 2002:adf:f588:0:b0:332:eb19:9530 with SMTP id f8-20020adff588000000b00332eb199530mr14573473wro.32.1701352195915; Thu, 30 Nov 2023 05:49:55 -0800 (PST) Received: from [192.168.69.100] (sev93-h02-176-184-17-116.dsl.sta.abo.bbox.fr. [176.184.17.116]) by smtp.gmail.com with ESMTPSA id h1-20020adfe981000000b00332f6202b82sm1595392wrm.9.2023.11.30.05.49.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Nov 2023 05:49:55 -0800 (PST) Message-ID: Date: Thu, 30 Nov 2023 14:49:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] Rename "QEMU global mutex" to "BQL" in comments and docs Content-Language: en-US To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Jean-Christophe Dubois , Fabiano Rosas , qemu-s390x@nongnu.org, Song Gao , Marcel Apfelbaum , Thomas Huth , Hyman Huang , Marcelo Tosatti , David Woodhouse , Andrey Smirnov , Peter Maydell , Kevin Wolf , Ilya Leoshkevich , Artyom Tarasenko , Mark Cave-Ayland , Max Filippov , Alistair Francis , Paul Durrant , Jagannathan Raman , Juan Quintela , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-arm@nongnu.org, Jason Wang , Gerd Hoffmann , Hanna Reitz , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , BALATON Zoltan , Daniel Henrique Barboza , Elena Ufimtseva , Aurelien Jarno , Hailiang Zhang , Roman Bolshakov , Huacai Chen , Fam Zheng , Eric Blake , Jiri Slaby , Alexander Graf , Liu Zhiwei , Weiwei Li , Eric Farman , Stafford Horne , David Hildenbrand , Markus Armbruster , Reinoud Zandijk , Palmer Dabbelt , Cameron Esfahani , xen-devel@lists.xenproject.org, Pavel Dovgalyuk , qemu-riscv@nongnu.org, Aleksandar Rikalo , John Snow , Sunil Muthuswamy , Michael Roth , David Gibson , "Michael S. Tsirkin" , Richard Henderson , Bin Meng , Stefano Stabellini , kvm@vger.kernel.org, qemu-block@nongnu.org, Halil Pasic , Peter Xu , Anthony Perard , Harsh Prateek Bora , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Eduardo Habkost , Paolo Bonzini , Vladimir Sementsov-Ogievskiy , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-ppc@nongnu.org, Christian Borntraeger , Akihiko Odaki , Leonardo Bras , Nicholas Piggin , Jiaxun Yang References: <20231129212625.1051502-1-stefanha@redhat.com> <20231129212625.1051502-7-stefanha@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20231129212625.1051502-7-stefanha@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 29/11/23 22:26, Stefan Hajnoczi wrote: > The term "QEMU global mutex" is identical to the more widely used Big > QEMU Lock ("BQL"). Update the code comments and documentation to use > "BQL" instead of "QEMU global mutex". > > Signed-off-by: Stefan Hajnoczi > --- > docs/devel/multi-thread-tcg.rst | 7 +++---- > docs/devel/qapi-code-gen.rst | 2 +- > docs/devel/replay.rst | 2 +- > docs/devel/multiple-iothreads.txt | 16 ++++++++-------- > include/block/blockjob.h | 6 +++--- > include/io/task.h | 2 +- > include/qemu/coroutine-core.h | 2 +- > include/qemu/coroutine.h | 2 +- > hw/block/dataplane/virtio-blk.c | 8 ++++---- > hw/block/virtio-blk.c | 2 +- > hw/scsi/virtio-scsi-dataplane.c | 6 +++--- > net/tap.c | 2 +- > 12 files changed, 28 insertions(+), 29 deletions(-) > diff --git a/include/block/blockjob.h b/include/block/blockjob.h > index e594c10d23..b2bc7c04d6 100644 > --- a/include/block/blockjob.h > +++ b/include/block/blockjob.h > @@ -54,7 +54,7 @@ typedef struct BlockJob { > > /** > * Speed that was set with @block_job_set_speed. > - * Always modified and read under QEMU global mutex (GLOBAL_STATE_CODE). > + * Always modified and read under BQL (GLOBAL_STATE_CODE). "under the BQL" > */ > int64_t speed; > > @@ -66,7 +66,7 @@ typedef struct BlockJob { > > /** > * Block other operations when block job is running. > - * Always modified and read under QEMU global mutex (GLOBAL_STATE_CODE). > + * Always modified and read under BQL (GLOBAL_STATE_CODE). Ditto, > */ > Error *blocker; > > @@ -89,7 +89,7 @@ typedef struct BlockJob { > > /** > * BlockDriverStates that are involved in this block job. > - * Always modified and read under QEMU global mutex (GLOBAL_STATE_CODE). > + * Always modified and read under BQL (GLOBAL_STATE_CODE). Ditto. > */ > GSList *nodes; > } BlockJob; Reviewed-by: Philippe Mathieu-Daudé