From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 632EBC6FD18 for ; Wed, 19 Apr 2023 10:59:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pp5Vq-0005Wl-7I; Wed, 19 Apr 2023 06:58:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pp5Vj-0005WS-Li for qemu-devel@nongnu.org; Wed, 19 Apr 2023 06:58:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pp5Va-0007VS-7S for qemu-devel@nongnu.org; Wed, 19 Apr 2023 06:57:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681901873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfNjgjtVx/hPPqKl1yzQUs5nxxWmj2TDCwmMP8Cg278=; b=azSB4rWS6eFI/oC3YqWNdHRiLB97+NYe4NWxMSwVoW9g97xd4p9ObLgKzq98qO8wqSuEAU SxTMgqcsrl7SKok1pnqmO36mpQf7Xr5AfRTN6xmxRDP6xt73W47VjKBw4tlX/zjm82ImhJ aT3fu81rsfQxnjdMRXuIbhaxZ9TfUvs= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-prnQrJomMD6JUs4jjr7FQg-1; Wed, 19 Apr 2023 06:57:51 -0400 X-MC-Unique: prnQrJomMD6JUs4jjr7FQg-1 Received: by mail-ed1-f69.google.com with SMTP id u12-20020a50c04c000000b00506880aeb5dso7182076edd.10 for ; Wed, 19 Apr 2023 03:57:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681901870; x=1684493870; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VfNjgjtVx/hPPqKl1yzQUs5nxxWmj2TDCwmMP8Cg278=; b=QucrwyfUvuvoN8BCDeGfgelJujSq/5lW6Zk5Y9JNR8inPn1UW1NduhA0nqDqeKXtN7 RmtddoRAH33uLGBOENQcUsfmHcpEr3TqW2OXvrNwnlcBZIJkvjMD/bnQwqlbS51WkHTu FUtM0bqib5g5+EyFB9jaELP7ogCA7bw5gMdowZdfAqxe00LiJFOXBRGut3xuAvqfgDuV 9VDHmFrsAZufA79cG7MQiiZ1B8Z4swVcH1f76vm0aIRFN323bTUmuwecygXCcNSubV5O 6lq4f4ASjDFGLLpfMqSurJWOPTmxjSjJtKQ8P05J5AeQAr7J44TcceWI9Vl5sinlqSEh ix9Q== X-Gm-Message-State: AAQBX9cNsz8xtOHBq7y8Wq5lhjGk5WaZwknxkWCoML+kwLpwx5RH/f4i FrR5uaApDcPQHPSiT8LJieo2kLZmNDhZjA67TJtd2Rc1IBstcUx/MmqQOKU9DvFMcMSW1tWrMzA y0PNtxLqlX3lFros= X-Received: by 2002:a17:906:5289:b0:94e:fd09:a02d with SMTP id c9-20020a170906528900b0094efd09a02dmr15050936ejm.47.1681901870180; Wed, 19 Apr 2023 03:57:50 -0700 (PDT) X-Google-Smtp-Source: AKy350arqxV3NTRestQI0A6aKvORJEjSWmfMgZ4J0xntP4A+ctG6k/ou77dEOfYvvZG430+2+rLb+Q== X-Received: by 2002:a17:906:5289:b0:94e:fd09:a02d with SMTP id c9-20020a170906528900b0094efd09a02dmr15050918ejm.47.1681901869776; Wed, 19 Apr 2023 03:57:49 -0700 (PDT) Received: from ?IPV6:2003:cf:d71b:cc43:1955:48c6:4ddb:556c? (p200300cfd71bcc43195548c64ddb556c.dip0.t-ipconnect.de. [2003:cf:d71b:cc43:1955:48c6:4ddb:556c]) by smtp.gmail.com with ESMTPSA id q16-20020a1709060f9000b0094e954fd015sm9367390ejj.175.2023.04.19.03.57.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 03:57:49 -0700 (PDT) Message-ID: Date: Wed, 19 Apr 2023 12:57:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [Virtio-fs] [PATCH 2/4] vhost-user: Interface for migration state transfer Content-Language: en-US To: Stefan Hajnoczi , Eugenio Perez Martin Cc: Juan Quintela , Stefan Hajnoczi , "Michael S . Tsirkin" , qemu-devel@nongnu.org, virtio-fs@redhat.com, Anton Kuchin References: <20230411150515.14020-1-hreitz@redhat.com> <20230411150515.14020-3-hreitz@redhat.com> <20230412210641.GC2813183@fedora> <20230417153810.GE3852722@fedora> <20230418175924.GB4041499@fedora> From: Hanna Czenczek In-Reply-To: <20230418175924.GB4041499@fedora> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=hreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.597, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 18.04.23 19:59, Stefan Hajnoczi wrote: > On Tue, Apr 18, 2023 at 10:09:30AM +0200, Eugenio Perez Martin wrote: >> On Mon, Apr 17, 2023 at 9:33 PM Stefan Hajnoczi wrote: >>> On Mon, 17 Apr 2023 at 15:10, Eugenio Perez Martin wrote: >>>> On Mon, Apr 17, 2023 at 5:38 PM Stefan Hajnoczi wrote: >>>>> On Thu, Apr 13, 2023 at 12:14:24PM +0200, Eugenio Perez Martin wrote: >>>>>> On Wed, Apr 12, 2023 at 11:06 PM Stefan Hajnoczi wrote: >>>>>>> On Tue, Apr 11, 2023 at 05:05:13PM +0200, Hanna Czenczek wrote: >>>>>>>> So-called "internal" virtio-fs migration refers to transporting the >>>>>>>> back-end's (virtiofsd's) state through qemu's migration stream. To do >>>>>>>> this, we need to be able to transfer virtiofsd's internal state to and >>>>>>>> from virtiofsd. >>>>>>>> >>>>>>>> Because virtiofsd's internal state will not be too large, we believe it >>>>>>>> is best to transfer it as a single binary blob after the streaming >>>>>>>> phase. Because this method should be useful to other vhost-user >>>>>>>> implementations, too, it is introduced as a general-purpose addition to >>>>>>>> the protocol, not limited to vhost-user-fs. >>>>>>>> >>>>>>>> These are the additions to the protocol: >>>>>>>> - New vhost-user protocol feature VHOST_USER_PROTOCOL_F_MIGRATORY_STATE: >>>>>>>> This feature signals support for transferring state, and is added so >>>>>>>> that migration can fail early when the back-end has no support. >>>>>>>> >>>>>>>> - SET_DEVICE_STATE_FD function: Front-end and back-end negotiate a pipe >>>>>>>> over which to transfer the state. The front-end sends an FD to the >>>>>>>> back-end into/from which it can write/read its state, and the back-end >>>>>>>> can decide to either use it, or reply with a different FD for the >>>>>>>> front-end to override the front-end's choice. >>>>>>>> The front-end creates a simple pipe to transfer the state, but maybe >>>>>>>> the back-end already has an FD into/from which it has to write/read >>>>>>>> its state, in which case it will want to override the simple pipe. >>>>>>>> Conversely, maybe in the future we find a way to have the front-end >>>>>>>> get an immediate FD for the migration stream (in some cases), in which >>>>>>>> case we will want to send this to the back-end instead of creating a >>>>>>>> pipe. >>>>>>>> Hence the negotiation: If one side has a better idea than a plain >>>>>>>> pipe, we will want to use that. >>>>>>>> >>>>>>>> - CHECK_DEVICE_STATE: After the state has been transferred through the >>>>>>>> pipe (the end indicated by EOF), the front-end invokes this function >>>>>>>> to verify success. There is no in-band way (through the pipe) to >>>>>>>> indicate failure, so we need to check explicitly. >>>>>>>> >>>>>>>> Once the transfer pipe has been established via SET_DEVICE_STATE_FD >>>>>>>> (which includes establishing the direction of transfer and migration >>>>>>>> phase), the sending side writes its data into the pipe, and the reading >>>>>>>> side reads it until it sees an EOF. Then, the front-end will check for >>>>>>>> success via CHECK_DEVICE_STATE, which on the destination side includes >>>>>>>> checking for integrity (i.e. errors during deserialization). >>>>>>>> >>>>>>>> Suggested-by: Stefan Hajnoczi >>>>>>>> Signed-off-by: Hanna Czenczek >>>>>>>> --- >>>>>>>> include/hw/virtio/vhost-backend.h | 24 +++++ >>>>>>>> include/hw/virtio/vhost.h | 79 ++++++++++++++++ >>>>>>>> hw/virtio/vhost-user.c | 147 ++++++++++++++++++++++++++++++ >>>>>>>> hw/virtio/vhost.c | 37 ++++++++ >>>>>>>> 4 files changed, 287 insertions(+) >>>>>>>> >>>>>>>> diff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhost-backend.h >>>>>>>> index ec3fbae58d..5935b32fe3 100644 >>>>>>>> --- a/include/hw/virtio/vhost-backend.h >>>>>>>> +++ b/include/hw/virtio/vhost-backend.h >>>>>>>> @@ -26,6 +26,18 @@ typedef enum VhostSetConfigType { >>>>>>>> VHOST_SET_CONFIG_TYPE_MIGRATION = 1, >>>>>>>> } VhostSetConfigType; >>>>>>>> >>>>>>>> +typedef enum VhostDeviceStateDirection { >>>>>>>> + /* Transfer state from back-end (device) to front-end */ >>>>>>>> + VHOST_TRANSFER_STATE_DIRECTION_SAVE = 0, >>>>>>>> + /* Transfer state from front-end to back-end (device) */ >>>>>>>> + VHOST_TRANSFER_STATE_DIRECTION_LOAD = 1, >>>>>>>> +} VhostDeviceStateDirection; >>>>>>>> + >>>>>>>> +typedef enum VhostDeviceStatePhase { >>>>>>>> + /* The device (and all its vrings) is stopped */ >>>>>>>> + VHOST_TRANSFER_STATE_PHASE_STOPPED = 0, >>>>>>>> +} VhostDeviceStatePhase; >>>>>>> vDPA has: >>>>>>> >>>>>>> /* Suspend a device so it does not process virtqueue requests anymore >>>>>>> * >>>>>>> * After the return of ioctl the device must preserve all the necessary state >>>>>>> * (the virtqueue vring base plus the possible device specific states) that is >>>>>>> * required for restoring in the future. The device must not change its >>>>>>> * configuration after that point. >>>>>>> */ >>>>>>> #define VHOST_VDPA_SUSPEND _IO(VHOST_VIRTIO, 0x7D) >>>>>>> >>>>>>> /* Resume a device so it can resume processing virtqueue requests >>>>>>> * >>>>>>> * After the return of this ioctl the device will have restored all the >>>>>>> * necessary states and it is fully operational to continue processing the >>>>>>> * virtqueue descriptors. >>>>>>> */ >>>>>>> #define VHOST_VDPA_RESUME _IO(VHOST_VIRTIO, 0x7E) >>>>>>> >>>>>>> I wonder if it makes sense to import these into vhost-user so that the >>>>>>> difference between kernel vhost and vhost-user is minimized. It's okay >>>>>>> if one of them is ahead of the other, but it would be nice to avoid >>>>>>> overlapping/duplicated functionality. >>>>>>> >>>>>> That's what I had in mind in the first versions. I proposed VHOST_STOP >>>>>> instead of VHOST_VDPA_STOP for this very reason. Later it did change >>>>>> to SUSPEND. >>>>> I noticed QEMU only calls ioctl(VHOST_VDPA_SUSPEND) and not >>>>> ioctl(VHOST_VDPA_RESUME). >>>>> >>>>> The doc comments in don't explain how the device can >>>>> leave the suspended state. Can you clarify this? >>>>> >>>> Do you mean in what situations or regarding the semantics of _RESUME? >>>> >>>> To me resume is an operation mainly to resume the device in the event >>>> of a VM suspension, not a migration. It can be used as a fallback code >>>> in some cases of migration failure though, but it is not currently >>>> used in qemu. >>> Is a "VM suspension" the QEMU HMP 'stop' command? >>> >>> I guess the reason why QEMU doesn't call RESUME anywhere is that it >>> resets the device in vhost_dev_stop()? >>> >> The actual reason for not using RESUME is that the ioctl was added >> after the SUSPEND design in qemu. Same as this proposal, it is was not >> needed at the time. >> >> In the case of vhost-vdpa net, the only usage of suspend is to fetch >> the vq indexes, and in case of error vhost already fetches them from >> guest's used ring way before vDPA, so it has little usage. >> >>> Does it make sense to combine SUSPEND and RESUME with Hanna's >>> SET_DEVICE_STATE_FD? For example, non-iterative migration works like >>> this: >>> - Saving the device's state is done by SUSPEND followed by >>> SET_DEVICE_STATE_FD. If the guest needs to continue executing (e.g. >>> savevm command or migration failed), then RESUME is called to >>> continue. >> I think the previous steps make sense at vhost_dev_stop, not virtio >> savevm handlers. To start spreading this logic to more places of qemu >> can bring confusion. > I don't think there is a way around extending the QEMU vhost's code > model. The current model in QEMU's vhost code is that the backend is > reset when the VM stops. This model worked fine for stateless devices > but it doesn't work for stateful devices. > > Imagine a vdpa-gpu device: you cannot reset the device in > vhost_dev_stop() and expect the GPU to continue working when > vhost_dev_start() is called again because all its state has been lost. > The guest driver will send requests that references a virtio-gpu > resources that no longer exist. > > One solution is to save the device's state in vhost_dev_stop(). I think > this is what you're suggesting. It requires keeping a copy of the state > and then loading the state again in vhost_dev_start(). I don't think > this approach should be used because it requires all stateful devices to > support live migration (otherwise they break across HMP 'stop'/'cont'). > Also, the device state for some devices may be large and it would also > become more complicated when iterative migration is added. > > Instead, I think the QEMU vhost code needs to be structured so that > struct vhost_dev has a suspended state: > > ,---------. > v | > started ------> stopped > \ ^ > \ | > -> suspended > > The device doesn't lose state when it enters the suspended state. It can > be resumed again. > > This is why I think SUSPEND/RESUME need to be part of the solution. > (It's also an argument for not including the phase argument in > SET_DEVICE_STATE_FD because the SUSPEND message is sent during > vhost_dev_stop() separately from saving the device's state.) So let me ask if I understand this protocol correctly: Basically, SUSPEND would ask the device to fully serialize its internal state, retain it in some buffer, and RESUME would then deserialize the state from the buffer, right? While this state needn’t necessarily be immediately migratable, I suppose (e.g. one could retain file descriptors there, and it doesn’t need to be a serialized byte buffer, but could still be structured), it would basically be a live migration implementation already.  As far as I understand, that’s why you suggest not running a SUSPEND+RESUME cycle on anything but live migration, right? I wonder how that model would then work with iterative migration, though.  Basically, for non-iterative migration, the back-end would expect SUSPEND first to flush its state out to a buffer, and then the state transfer would just copy from that buffer.  For iterative migration, though, there is no SUSPEND first, so the back-end must implicitly begin to serialize its state and send it over.  I find that a bit strange. Also, how would this work with currently migratable stateless back-ends?  Do they already implement SUSPEND+RESUME as no-ops?  If not, I think we should detect stateless back-ends and skip the operations in qemu lest we have to update those back-ends for no real reason. Hanna