From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9rl-0005Q7-Nw for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:26:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX9rh-00022X-Hb for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:26:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX9rh-00022B-Bv for qemu-devel@nongnu.org; Tue, 09 Aug 2016 12:26:53 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 05FDD4E33C for ; Tue, 9 Aug 2016 16:26:53 +0000 (UTC) References: <1470756748-18933-1-git-send-email-berrange@redhat.com> <1470756748-18933-12-git-send-email-berrange@redhat.com> <20160809162447.GM1530@redhat.com> From: Paolo Bonzini Message-ID: Date: Tue, 9 Aug 2016 18:26:49 +0200 MIME-Version: 1.0 In-Reply-To: <20160809162447.GM1530@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.8 v1 11/60] trace: remove use of event ID enums from APIs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On 09/08/2016 18:24, Daniel P. Berrange wrote: >>> > > -static inline TraceEventID trace_event_get_id(TraceEvent *ev) >>> > > +static inline size_t trace_event_get_id(TraceEvent *ev) >>> > > { >>> > > assert(ev != NULL); >>> > > return ev->id; >> > >> > Perhaps "unsigned" is a better match than size_t? > I don't mind either way - I just happen to personally always use size_t > for anything that ends up being used primarily as an array index. Makes sense. I was thinking of simpletrace's 32-bit id instead. Paolo