Re: [Qemu-devel] [PATCH v2] scripts: add "git.orderfile" for ordering diff hunks by pathname patterns

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1467 bytes --]

On 12/05/2016 04:24 AM, Laszlo Ersek wrote:

> 
> I picked the below lines from Eric's feedback.
> 
>>> +qapi-schema*.json
>>> +qapi/*.json
>>> +include/qapi/visitor.h
>>> +include/qapi/visitor-impl.h
>>> +scripts/qapi.py
>>> +scripts/*.py
>>> +*.h
>>> +qapi/qapi-visit-core.c
>>
>> is the exact order or qapi files that important?
>> I'd rather we stuck to simple wildcards without
>> special casing visitors etc.
> 
> Eric indicated this specific order was helpful for QAPI work.

In fact, what I would recommend is that we do the minimal file now, and
then subsequent series (such as if I have more QAPI work) can add their
further tweaks as part of the series where those tweaks aid review.  So
I'd be just fine omitting the visitor special-casing if it helps get the
patch in faster.

> I suggest we go ahead with this posting (or v1), then people can submit
> whatever improvements they deem fit, from their personal experience. I
> think the initial version should be minimal and non-controversial.
> 
> We've already spent a disproportionate amount of time discussing this item.

Indeed, especially for something that still requires manual
configuration from each developer to make use of it (it's a shame git
doesn't yet have automatic support for .gitorderfile, like it does for
.gitignore or .gitattributes).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]