From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsbCE-0002u4-3g for qemu-devel@nongnu.org; Fri, 07 Oct 2016 15:52:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsbCB-0005FU-Uy for qemu-devel@nongnu.org; Fri, 07 Oct 2016 15:52:41 -0400 References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-17-git-send-email-vsementsov@virtuozzo.com> From: Eric Blake Message-ID: Date: Fri, 7 Oct 2016 14:52:30 -0500 MIME-Version: 1.0 In-Reply-To: <1475232808-4852-17-git-send-email-vsementsov@virtuozzo.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bp62HxxoPGd41gctr4bt8wuAXP3Btn16s" Subject: Re: [Qemu-devel] [PATCH 16/22] qmp: add persistent flag to block-dirty-bitmap-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, armbru@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Bp62HxxoPGd41gctr4bt8wuAXP3Btn16s From: Eric Blake To: Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, armbru@redhat.com, jsnow@redhat.com, famz@redhat.com, den@openvz.org, stefanha@redhat.com, pbonzini@redhat.com Message-ID: Subject: Re: [PATCH 16/22] qmp: add persistent flag to block-dirty-bitmap-add References: <1475232808-4852-1-git-send-email-vsementsov@virtuozzo.com> <1475232808-4852-17-git-send-email-vsementsov@virtuozzo.com> In-Reply-To: <1475232808-4852-17-git-send-email-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/30/2016 05:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. > Default is false. >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Denis V. Lunev > --- > blockdev.c | 12 +++++++++++- > qapi/block-core.json | 7 ++++++- > qmp-commands.hx | 5 ++++- This and later patches have conflicts with recent changes in the tree that removed qmp-commands.hx; hopefully shouldn't impact review of this series too badly. > +++ b/qapi/block-core.json > @@ -1235,10 +1235,15 @@ > # @granularity: #optional the bitmap granularity, default is 64k for > # block-dirty-bitmap-add > # > +# @persistent: #optional the bitmap is persistent, i.e. it will be sav= ed to > +# corresponding block device on it's close. Default is fa= lse. s/corresponding/the corresponding/ s/it's/its/ ("it's" is only appropriate if you can substitute "it is" or "it has") > @@ -1458,6 +1458,9 @@ Arguments: > - "node": device/node on which to create dirty bitmap (json-string) > - "name": name of the new dirty bitmap (json-string) > - "granularity": granularity to track writes with (int, optional) > +- "persistent": bitmap will be saved to corresponding block device > + on it's close. Block driver should maintain persistent= bitmaps One nice benefit of rebasing on top of qmp-commands.hx being removed is that you don't have to repeat yourself :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Bp62HxxoPGd41gctr4bt8wuAXP3Btn16s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX9/z+AAoJEKeha0olJ0NqzlgH/iqCvluDq39OvZn4ucn8wJjW seb02CWItdViut3xWOnbJ/amVb51FBUMdbmuoMAqP0D8VU4hnCeMFR9kaXvcQvIw xH+WfvTrtUjkseaTiV3dbTBkU39FMGdmrLy6lm+wAmaM9YDvE3atLvBOyaax0+wD DzltxLkrilYm6bglqDrNtloYYgI5UHD5r3RTTL6ef1jJp/H5CfKRHeRx6hDfUObs twHLtK1pnFdn0LGp3APiqYz69wmmkWc95Uh4i5LEo2hKAo/3Mm/Ouqd7Mye87Wl4 XRlfk62uA95y3pK5ICvOfOPQ2Jz7XbMVIIzd0FR7mWBrSxbUKqaQWBQJ7Lh5Bm8= =cfjQ -----END PGP SIGNATURE----- --Bp62HxxoPGd41gctr4bt8wuAXP3Btn16s--