From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Sriram Yagnaraman" <sriram.yagnaraman@est.tech>,
"Jason Wang" <jasowang@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
"Klaus Jensen" <its@irrelevant.dk>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v3 6/7] pcie_sriov: Reuse SR-IOV VF device instances
Date: Tue, 13 Feb 2024 21:17:36 +0900 [thread overview]
Message-ID: <fce960cf-a482-4c09-83d0-0881d4e0fb29@daynix.com> (raw)
In-Reply-To: <20240213060116-mutt-send-email-mst@kernel.org>
On 2024/02/13 20:01, Michael S. Tsirkin wrote:
> On Mon, Feb 12, 2024 at 07:20:34PM +0900, Akihiko Odaki wrote:
>> Disable SR-IOV VF devices by reusing code to power down PCI devices
>> instead of removing them when the guest requests to disable VFs. This
>> allows to realize devices and report VF realization errors at PF
>> realization time.
>>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>
> It is simpler for sure, but I am worried that all of these
> unused VFs will consume lots of resources even if never
> enabled. Thoughts?
My rationale behind this change is that the resources should be
allocated when the PF is realized to ensure the resources are available
when the guest requests to enable VFs.
When it is necessary to allocate resources dynamically, the conventional
hotplug mechanism should be used instead since the SR-IOV interface is
not designed to report resource allocation errors.
next prev parent reply other threads:[~2024-02-13 12:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 10:20 [PATCH v3 0/7] hw/pci: SR-IOV related fixes and improvements Akihiko Odaki
2024-02-12 10:20 ` [PATCH v3 1/7] hw/pci: Use -1 as a default value for rombar Akihiko Odaki
2024-02-12 10:20 ` [PATCH v3 2/7] hw/pci: Determine if rombar is explicitly enabled Akihiko Odaki
2024-02-13 10:52 ` Michael S. Tsirkin
2024-02-13 12:07 ` Akihiko Odaki
2024-02-12 10:20 ` [PATCH v3 3/7] vfio: Avoid inspecting option QDict for rombar Akihiko Odaki
2024-02-12 10:20 ` [PATCH v3 4/7] hw/qdev: Remove opts member Akihiko Odaki
2024-02-12 10:20 ` [PATCH v3 5/7] pcie_sriov: Validate NumVFs Akihiko Odaki
2024-02-13 10:59 ` Michael S. Tsirkin
2024-02-13 14:29 ` Akihiko Odaki
2024-02-12 10:20 ` [PATCH v3 6/7] pcie_sriov: Reuse SR-IOV VF device instances Akihiko Odaki
2024-02-13 11:01 ` Michael S. Tsirkin
2024-02-13 12:17 ` Akihiko Odaki [this message]
2024-02-12 10:20 ` [PATCH v3 7/7] pcie_sriov: Release VFs failed to realize Akihiko Odaki
[not found] ` <CGME20240212102210epcas2p4346c0dfc475ecee9f359d634eba46783@epcms2p8>
2024-02-13 8:51 ` [PATCH v3 6/7] pcie_sriov: Reuse SR-IOV VF device instances Minwoo Im
2024-02-13 12:26 ` Akihiko Odaki
2024-02-13 13:48 ` Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fce960cf-a482-4c09-83d0-0881d4e0fb29@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=alex.williamson@redhat.com \
--cc=berrange@redhat.com \
--cc=clg@redhat.com \
--cc=eduardo@habkost.net \
--cc=its@irrelevant.dk \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sriram.yagnaraman@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).