Re: [PATCH v7 09/36] hw/pci-host/gpex-acpi: Use build_pci_host_bridge_osc_method

[Eric Auger <eric.auger@redhat.com>]

Hi Michael,

On 8/4/25 8:29 AM, Michael Tokarev wrote:
> On 03.08.2025 19:49, Eric Auger wrote:
> ...
>> I have not proposed anything ;-) - sorry I am on vacation - I was trying
>> to enumerate the various config settings and to me dependencies should
>> be resolved so I fail to understand. Unfortunately I cannot test because
>> the problem happens with a custom microvm.mak. I would need this latter
>> to reproduce and try to fix.
>>
>> if the microvm.mak selects PCI_EXPRESS_GENERIC_BRIDGE (which selects
>> PCI_EXPRESS which itself selects PCI) and ACPI_HW_REDUCED (which selects
>> ACPI), the imply ACPI_PCI should end up as a selection because PCI and
>> ACPI are resolved. At least that's my understanding. Reading it again,
>> please can you check whether ACPI_HW_REDUCED is selected *before*
>> PCI_EXPRESS_GENERIC_BRIDGE in the custom microvm.mak. Depending on the
>> order of dependency resolution it might make a difference. Otherwise
>> please can you send the full microvm.mak and configure command so that I
>> can try reproducing. Thanks Eric
>
> All the details were in my very first reply to the original patch:
> https://lore.kernel.org/qemu-devel/ddf6f9e3-daaa-4ea1-a5e6-d402a75524c8@tls.msk.ru/
>

Sorry I was confused by the fact the microvm.mak was not upstream and
its content was cut in your original report.

I was able to reproduce and could check that both ACPI and PCI are set
since objects that depend on them are compiled. However
ACPI_PCI which depend on both and which is implied by
PCI_EXPRESS_GENERIC_BRIDGE is not set as opposed to what I would have
expected. 
So I sent "[PATCH for 10.1] microvm: Explicitly select ACPI_PCI" as a
tentative fix of your issue. It looks similar to PC setup. An
alternative could be to set it in your .mak file.

Nevetheless I still fail to understand what prevents the imply from
beeing active as a select here. Maybe that's due to the "eveythning
unset by default".

Thanks

Eric





>
> Thanks,
>
> /mjt
>