From: LIU Zhiwei <zhiwei_liu@c-sky.com>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: palmer@dabbelt.com, wenmeng_zhang@c-sky.com,
Alistair.Francis@wdc.com, wxy194768@alibaba-inc.com
Subject: Re: [PATCH 1/1] tcg/tcg-op: nonatomic_op should work with smaller memop
Date: Thu, 2 Jul 2020 07:44:08 +0800 [thread overview]
Message-ID: <fcfd644f-fcec-72ca-ebbe-d2eaa60bdeac@c-sky.com> (raw)
In-Reply-To: <e828263f-e592-d787-b4cd-44c41a41e7f3@linaro.org>
On 2020/7/2 0:25, Richard Henderson wrote:
> On 7/1/20 8:21 AM, LIU Zhiwei wrote:
>> - tcg_gen_qemu_ld_i32(t1, addr, idx, memop & ~MO_SIGN);
>> + tcg_gen_qemu_ld_i32(t1, addr, idx, memop);
>> + tcg_gen_ext_i32(val, val, memop);
>> gen(t2, t1, val);
> I was just about to post a simiar patch.
> The difference with mine is that I do not modify val:
>
> - gen(t2, t1, val);
> + tcg_gen_ext_i32(t2, val, memop);
> + gen(t2, t1, t2);
I see. So just ignore this patch.:-)
Zhiwei
>
> r~
prev parent reply other threads:[~2020-07-01 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 15:21 [PATCH 1/1] tcg/tcg-op: nonatomic_op should work with smaller memop LIU Zhiwei
2020-07-01 16:25 ` Richard Henderson
2020-07-01 23:44 ` LIU Zhiwei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcfd644f-fcec-72ca-ebbe-d2eaa60bdeac@c-sky.com \
--to=zhiwei_liu@c-sky.com \
--cc=Alistair.Francis@wdc.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wenmeng_zhang@c-sky.com \
--cc=wxy194768@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).