From: Hollis Blanchard <hollisb@us.ibm.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: qemu/target-ppc helper.c op.c op_helper.c op_he...
Date: Wed, 19 Sep 2007 16:35:24 +0000 (UTC) [thread overview]
Message-ID: <fcrj4c$6dn$1@sea.gmane.org> (raw)
In-Reply-To: E1IXsM0-0005Sa-Ud@cvs.savannah.gnu.org
On Wed, 19 Sep 2007 05:44:04 +0000, Jocelyn Mayer wrote:
> CVSROOT: /sources/qemu
> Module name: qemu
> Changes by: Jocelyn Mayer <j_mayer> 07/09/19 05:44:04
>
> Modified files:
> target-ppc : helper.c op.c op_helper.c op_helper.h
> translate.c
>
> Log message:
> Code provision for PowerPC BookE MMU model support.
> Better MSR flags initialisation.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/helper.c?cvsroot=qemu&r1=1.53&r2=1.54
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op.c?cvsroot=qemu&r1=1.40&r2=1.41
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.37&r2=1.38
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.h?cvsroot=qemu&r1=1.11&r2=1.12
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/translate.c?cvsroot=qemu&r1=1.64&r2=1.65
tlbwe and tlbre do not use PID; they use MMUCR[STID].
Also, IBM and Freescale Book E architectures are very different here, so I
would suggest naming these functions something more specific than
e.g. "do_booke_tlbwe". You're really implementing IBM's 440
architecture here.
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2007-09-19 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-19 5:44 [Qemu-devel] qemu/target-ppc helper.c op.c op_helper.c op_he Jocelyn Mayer
2007-09-19 16:35 ` Hollis Blanchard [this message]
2007-09-19 18:40 ` [Qemu-devel] " J. Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='fcrj4c$6dn$1@sea.gmane.org' \
--to=hollisb@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).