From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IY2Wm-0003Tc-87
	for qemu-devel@nongnu.org; Wed, 19 Sep 2007 12:35:52 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IY2Wl-0003SK-IM
	for qemu-devel@nongnu.org; Wed, 19 Sep 2007 12:35:51 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IY2Wl-0003S0-6p
	for qemu-devel@nongnu.org; Wed, 19 Sep 2007 12:35:51 -0400
Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1IY2Wk-000775-QA
	for qemu-devel@nongnu.org; Wed, 19 Sep 2007 12:35:51 -0400
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1IY2WV-0002Wg-AV
	for qemu-devel@nongnu.org; Wed, 19 Sep 2007 18:35:35 +0200
Received: from user-0vvdaf6.cable.mindspring.com ([63.246.169.230])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 19 Sep 2007 18:35:35 +0200
Received: from hollisb by user-0vvdaf6.cable.mindspring.com with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Wed, 19 Sep 2007 18:35:35 +0200
From: Hollis Blanchard <hollisb@us.ibm.com>
Date: Wed, 19 Sep 2007 16:35:24 +0000 (UTC)
Message-ID: <fcrj4c$6dn$1@sea.gmane.org>
References: <E1IXsM0-0005Sa-Ud@cvs.savannah.gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: news <news@sea.gmane.org>
Subject: [Qemu-devel] Re: qemu/target-ppc helper.c op.c op_helper.c op_he...
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, 19 Sep 2007 05:44:04 +0000, Jocelyn Mayer wrote:

> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Jocelyn Mayer <j_mayer>	07/09/19 05:44:04
> 
> Modified files:
> 	target-ppc     : helper.c op.c op_helper.c op_helper.h 
> 	                 translate.c 
> 
> Log message:
> 	Code provision for PowerPC BookE MMU model support.
> 	Better MSR flags initialisation.
> 
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/helper.c?cvsroot=qemu&r1=1.53&r2=1.54
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op.c?cvsroot=qemu&r1=1.40&r2=1.41
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.c?cvsroot=qemu&r1=1.37&r2=1.38
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/op_helper.h?cvsroot=qemu&r1=1.11&r2=1.12
> http://cvs.savannah.gnu.org/viewcvs/qemu/target-ppc/translate.c?cvsroot=qemu&r1=1.64&r2=1.65

tlbwe and tlbre do not use PID; they use MMUCR[STID].

Also, IBM and Freescale Book E architectures are very different here, so I
would suggest naming these functions something more specific than
e.g. "do_booke_tlbwe". You're really implementing IBM's 440
architecture here.

-- 
Hollis Blanchard
IBM Linux Technology Center