From: Max Reitz <mreitz@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com,
jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] hw/block/fdc: floppy command FIFO memory initialization
Date: Wed, 29 May 2019 23:38:44 +0200 [thread overview]
Message-ID: <fd085c62-35fb-a054-7a75-cad24eda07a1@redhat.com> (raw)
In-Reply-To: <1559154027-282547-1-git-send-email-andrey.shinkevich@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
On 29.05.19 20:20, Andrey Shinkevich wrote:
> The uninitialized memory allocated for the command FIFO of the
> floppy controller during the VM hardware initialization incurs
> many unwanted reports by Valgrind when VM state is being saved.
> That verbosity hardens a search for the real memory issues when
> the iotests run. Particularly, the patch eliminates 20 unnecessary
> reports of the Valgrind tool in the iotest #169.
>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
> v2:
> 01: The pointer unnecessary check 'if (fdctrl->fifo)' was removed
> as suggested by John.
>
> hw/block/fdc.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block-on-kevin branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block-on-kevin
(To become my block branch when my current pull request is done.)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-29 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 18:20 [Qemu-devel] [PATCH v2] hw/block/fdc: floppy command FIFO memory initialization Andrey Shinkevich
2019-05-29 18:22 ` John Snow
2019-05-29 18:34 ` John Snow
2019-05-29 21:38 ` Max Reitz [this message]
2019-05-30 6:47 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd085c62-35fb-a054-7a75-cad24eda07a1@redhat.com \
--to=mreitz@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).