From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1998DC433DB for ; Tue, 16 Mar 2021 15:08:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C013264FF4 for ; Tue, 16 Mar 2021 15:08:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C013264FF4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMBJP-0000Wv-VG for qemu-devel@archiver.kernel.org; Tue, 16 Mar 2021 11:08:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMBIK-000882-04 for qemu-devel@nongnu.org; Tue, 16 Mar 2021 11:07:40 -0400 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]:42629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMBII-00039I-B7 for qemu-devel@nongnu.org; Tue, 16 Mar 2021 11:07:39 -0400 Received: by mail-qt1-x82c.google.com with SMTP id l13so11860658qtu.9 for ; Tue, 16 Mar 2021 08:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mU2UTvC2h1JsJsvg+raT6xisMpRUMwtOBVGDb4u75UA=; b=LRPrHWSlZj314Ih0AKT3MW2crTK5loj3PhrvsxHQDY+nRatyh2onWe33aLHIz4vgP3 ApoyCiwdt6bTRTdJMX/YByNVUsuTdHlupM2tAvLOgJjdgGbq0d4DPWxQfS3diSzFGkPA mCGwjn0drEXNtAlOc2mdIAAEbacvgJKejmmV2lcNWg5HVYwsQqMTdnKzRFv4EKado7jE 0jnDqnKMSpdmR87GgdT+FbD1Nh6hgHFHO8673sRbWFxbyOVmhJk2Sa8WucOZW9ZCqkjY cbJ5GEaJaeRFZny+ut79TyJEslCBEDMLX1xfZ/D5pnvbotgPh1sfxS/H1ZMAESiVb+0k MK+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mU2UTvC2h1JsJsvg+raT6xisMpRUMwtOBVGDb4u75UA=; b=WnzRhzhlkQnQu0ADvvh8Po2WN3U41QHvSMW57sUorL1djbRlc2AuvHBmdyN98ukbr0 DBGh1Fq+0OCxSj52zpCEHIVeQBE75UVdxB3g/e8RtFngwcv5z2+lLOWMMQigzCZr61Ri U7VBljPyWmfRiazSVMNhlfugoRg8y/XWhNR2AXU1MVARaSVLbGJaOvJToQt6QHHXwpjn C4jzOWTjk/njbsMLuMFIpbGbsWg4eZApex3boVhiqr0bWJbg8RCMV2K/oVNG2oPnM5ZA W8uw8mMlj3d7pCynm/l2qlCCGRobuehTErflO63AFfyVklspVDCk4WfZHdethWZURwb2 VHqQ== X-Gm-Message-State: AOAM53297IJqjkPHYbpDMa9vr/wwLv3f1CyHGB6g0HDb3M1ESSnw8Zev /2okiXSup1TdfIxXrMmajP0OLFkk3xFWLELN X-Google-Smtp-Source: ABdhPJxZociFQClvwHRMuoAtJdjloVQuHcpFsv72LpdgkkRx2iOHhdqGRGSU7BW82j/fA1aSFpN1fQ== X-Received: by 2002:ac8:44b2:: with SMTP id a18mr89634qto.285.1615907257230; Tue, 16 Mar 2021 08:07:37 -0700 (PDT) Received: from [10.10.121.52] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id b22sm15422110qkk.45.2021.03.16.08.07.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Mar 2021 08:07:36 -0700 (PDT) Subject: Re: Bug in tlbi_aa64_vae2is_write: tlbbits_for_regime called with swapped ARMMMUIdx_ values? To: Rebecca Cran References: <54fb8499-0758-a554-6103-5b56d784fda3@nuviainc.com> From: Richard Henderson Message-ID: Date: Tue, 16 Mar 2021 09:07:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <54fb8499-0758-a554-6103-5b56d784fda3@nuviainc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82c; envelope-from=richard.henderson@linaro.org; helo=mail-qt1-x82c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/15/21 11:33 PM, Rebecca Cran wrote: > I noticed the following in tlbi_aa64_vae2is_write: it appears that when calling > tlbbits_for_regime the ARMMMUIdx values are swapped? > > static void tlbi_aa64_vae2is_write(CPUARMState *env, const ARMCPRegInfo *ri, >                                    uint64_t value) > { >     CPUState *cs = env_cpu(env); >     uint64_t pageaddr = sextract64(value << 12, 0, 56); >     bool secure = arm_is_secure_below_el3(env); >     int mask = secure ? ARMMMUIdxBit_SE2 : ARMMMUIdxBit_E2; >     int bits = tlbbits_for_regime(env, secure ? ARMMMUIdx_E2 : ARMMMUIdx_SE2, Yep, good catch. r~ >                                   pageaddr); > >     tlb_flush_page_bits_by_mmuidx_all_cpus_synced(cs, pageaddr, mask, bits); > } >