From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, 1749393@bugs.launchpad.net
Subject: Re: [Qemu-devel] [PATCH] linux-user: Allocate extra space for brk in PIE executable
Date: Fri, 16 Mar 2018 19:44:55 +0800 [thread overview]
Message-ID: <fd1e45ca-53b5-1e3d-eacc-2c9a91467674@linaro.org> (raw)
In-Reply-To: <CAFEAcA_fABdsR8z4NTNP9Ux6ZLGVsfw5NpPyqB1HqV72_VjgDQ@mail.gmail.com>
On 03/16/2018 07:01 PM, Peter Maydell wrote:
> PS: do you know what the intention of the
> if (reserved_va) {
> mmap_next_start = reserved_va;
> }
> code in linux-user/main.c is? It seems a bit odd to say "ok,
> we have reserved a big region. we will start trying to mmap
> outside it.", especially when that region covers the full
> 4G that the guest can access...
My guess is that it probably should have been
mmap_next_start = MIN(TASK_UNMAPPED_BASE, reserved_va);
I can't think of any other reason it should be modified at all.
r~
prev parent reply other threads:[~2018-03-16 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 10:34 [Qemu-devel] [PATCH] linux-user: Allocate extra space for brk in PIE executable Richard Henderson
2018-03-16 11:01 ` Peter Maydell
2018-03-16 11:44 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd1e45ca-53b5-1e3d-eacc-2c9a91467674@linaro.org \
--to=richard.henderson@linaro.org \
--cc=1749393@bugs.launchpad.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).