From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYdnC-0007Mi-RJ for qemu-devel@nongnu.org; Mon, 08 Jan 2018 15:13:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYdn9-0002qz-I9 for qemu-devel@nongnu.org; Mon, 08 Jan 2018 15:13:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49700) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eYdn9-0002qV-Ai for qemu-devel@nongnu.org; Mon, 08 Jan 2018 15:13:07 -0500 References: <20180108172904.8772-1-f4bug@amsat.org> <20180108172904.8772-2-f4bug@amsat.org> From: Thomas Huth Message-ID: Date: Mon, 8 Jan 2018 21:13:00 +0100 MIME-Version: 1.0 In-Reply-To: <20180108172904.8772-2-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 01/12] slirp: remove QEMU_PACKED from structures with don't require it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Samuel Thibault , Jan Kiszka , "Michael S . Tsirkin" , Paolo Bonzini , Eric Blake Cc: qemu-devel@nongnu.org On 08.01.2018 18:28, Philippe Mathieu-Daud=C3=A9 wrote: > theses structures are not serialized and often store host pointers. Patch looks fine at a quick glance... did you check that migration still works (while there is network traffic going on in the guest)? Thomas