qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: qemu-devel@nongnu.org, mst@redhat.com, xieyongji@bytedance.com
Cc: marcel@holtmann.org
Subject: [PATCH v3 05/10] libvhost-user: Declare uffdio_register early to make it C90 compliant
Date: Wed, 21 Dec 2022 14:10:21 +0100	[thread overview]
Message-ID: <fd65fc53f4bf1dec4998edab8fb1155bf36ba241.1671628158.git.marcel@holtmann.org> (raw)
In-Reply-To: <cover.1671628158.git.marcel@holtmann.org>

When using libvhost-user source in an external project that wants to
comply with the C90 standard, it is best to declare variables before
code.

  CC       libvhost-user.o
libvhost-user.c: In function ‘generate_faults’:
libvhost-user.c:683:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  683 |         struct uffdio_register reg_struct;
      |         ^~~~~~

In this case, it is also simple enough and doesn't cause any extra
ifdef additions.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 subprojects/libvhost-user/libvhost-user.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c
index 211d31a4cc88..bf92cc85c086 100644
--- a/subprojects/libvhost-user/libvhost-user.c
+++ b/subprojects/libvhost-user/libvhost-user.c
@@ -626,6 +626,8 @@ generate_faults(VuDev *dev) {
         VuDevRegion *dev_region = &dev->regions[i];
         int ret;
 #ifdef UFFDIO_REGISTER
+        struct uffdio_register reg_struct;
+
         /*
          * We should already have an open ufd. Mark each memory
          * range as ufd.
@@ -659,7 +661,7 @@ generate_faults(VuDev *dev) {
                     "%s: Failed to madvise(NOHUGEPAGE) region %d: %s\n",
                     __func__, i, strerror(errno));
         }
-        struct uffdio_register reg_struct;
+
         reg_struct.range.start = (uintptr_t)dev_region->mmap_addr;
         reg_struct.range.len = dev_region->size + dev_region->mmap_offset;
         reg_struct.mode = UFFDIO_REGISTER_MODE_MISSING;
-- 
2.38.1



  parent reply	other threads:[~2022-12-21 13:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 13:10 [PATCH v3 00/10] Compiler warning fixes for libvhost-user,libvduse Marcel Holtmann
2022-12-21 13:10 ` [PATCH v3 01/10] libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU Marcel Holtmann
2022-12-21 13:10 ` [PATCH v3 02/10] libvhost-user: Replace typeof with __typeof__ Marcel Holtmann
2022-12-22  8:16   ` Paolo Bonzini
2022-12-22 20:37     ` Marcel Holtmann
2022-12-21 13:10 ` [PATCH v3 03/10] libvhost-user: Cast rc variable to avoid compiler warning Marcel Holtmann
2022-12-21 13:10 ` [PATCH v3 04/10] libvhost-user: Use unsigned int i for some for-loop iterations Marcel Holtmann
2022-12-21 13:10 ` Marcel Holtmann [this message]
2022-12-21 13:10 ` [PATCH v3 06/10] libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant Marcel Holtmann
2022-12-21 13:10 ` [PATCH v3 07/10] libvhost-user: Switch to unsigned int for inuse field in struct VuVirtq Marcel Holtmann
2022-12-21 13:10 ` [PATCH v3 08/10] libvduse: Provide _GNU_SOURCE when compiling outside of QEMU Marcel Holtmann
2022-12-21 13:10 ` [PATCH v3 09/10] libvduse: Switch to unsigned int for inuse field in struct VduseVirtq Marcel Holtmann
2022-12-21 13:10 ` [PATCH v3 10/10] libvduse: Fix assignment in vring_set_avail_event Marcel Holtmann
2022-12-22  8:09   ` Paolo Bonzini
2022-12-22 20:38     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd65fc53f4bf1dec4998edab8fb1155bf36ba241.1671628158.git.marcel@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).