From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, peter.maydell@linaro.org
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/4] target/arm: handle M-profile semihosting at translate time
Date: Fri, 6 Sep 2019 11:03:59 -0400 [thread overview]
Message-ID: <fd822874-4ffc-3417-d0ca-b82316de53b5@linaro.org> (raw)
In-Reply-To: <20190906124706.19145-2-alex.bennee@linaro.org>
On 9/6/19 8:47 AM, Alex Bennée wrote:
> + if (arm_dc_feature(s, ARM_FEATURE_M) &&
> + semihosting_enabled() &&
> +#ifndef CONFIG_USER_ONLY
> + s->current_el != 0 &&
> +#endif
This last should be !IS_USER(s), no ifdef.
r~
next prev parent reply other threads:[~2019-09-06 15:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 12:47 [Qemu-devel] [PATCH v3 0/4] semihosting fixes Alex Bennée
2019-09-06 12:47 ` [Qemu-devel] [PATCH v3 1/4] target/arm: handle M-profile semihosting at translate time Alex Bennée
2019-09-06 15:03 ` Richard Henderson [this message]
2019-09-06 12:47 ` [Qemu-devel] [PATCH v3 2/4] target/arm: handle A-profile " Alex Bennée
2019-09-06 12:54 ` Peter Maydell
2019-09-06 13:16 ` Alex Bennée
2019-09-06 13:33 ` Peter Maydell
2019-09-06 15:05 ` Richard Henderson
2019-09-06 12:47 ` [Qemu-devel] [PATCH v3 3/4] target/arm: remove run time semihosting checks Alex Bennée
2019-09-06 12:47 ` [Qemu-devel] [PATCH v3 4/4] atomic_template: fix indentation in GEN_ATOMIC_HELPER Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd822874-4ffc-3417-d0ca-b82316de53b5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).