From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F497C4707C for ; Fri, 12 Jan 2024 22:45:42 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rOQHP-0000ho-5g; Fri, 12 Jan 2024 17:45:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rOQHO-0000hY-Az for qemu-devel@nongnu.org; Fri, 12 Jan 2024 17:45:34 -0500 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rOQHM-0004Oe-FY for qemu-devel@nongnu.org; Fri, 12 Jan 2024 17:45:33 -0500 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-28b400f08a4so5786143a91.1 for ; Fri, 12 Jan 2024 14:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705099531; x=1705704331; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mjVocek/4APUMKGU1W7X2sTD3d4YNF0ORuHlQlujXO8=; b=PhfSLP1MVXekqRE44yKkfx+DZo3W+CjQ4sA8m6Jhy5k1RBUgkvGoNe+3mJ6SvzKJ0d MnyoGcRE1j1WTA+wn48FimSBg5+4MjiRblRLKxhBFMUxrDRozxzCtjAtlnQ08URVLecX w4vyGMGgdl9xO0NhamxL018bqv7MNZSMRA3S/YNNgNwa/2bpUyDpRgSLQH0Gn5NlrpT/ wgYDPEIxbptwsDCfG6UyAbMEACTYmwgShhnniauz1G/i22XdfiD9USkgNCjaY1Ltsl2E PnLzywC+bZKmdv2ZZCTOkmGdlRg0Evh3JAL/cfuT2kRsyShFRSTIMOEqfRZ4OvWVmdUk W/4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705099531; x=1705704331; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mjVocek/4APUMKGU1W7X2sTD3d4YNF0ORuHlQlujXO8=; b=unbM3DvmeKkGO73wp5QfglSVKhV3Yyp81b2b87+XlmqBjV4twiHRsyG+6soOFLNgSC LZ73HP2clyThGPGl2iw0C7nT7hD4rAPvSkWVk2Et4E8hmM37DBEm/ct3Weg427UxCvFi 0kAt/gce30XUqREj61d654RTazFEQQuVuhqb+3QtFOviWnmXkN0TqfWKBSoURqFgF+xZ tS6+3Qxv85JNscEkXE92IfRxwLUL8g9O0nukSNPlULjaEO5A7F9pFOuVrzAPAptd0EAM O3OTM5YLr479ye8ClEnwZMEg821IrmdND3Wyk62JPSLQZi/XZ81Jd4O4W0VoxkMAoTsz 3VdQ== X-Gm-Message-State: AOJu0YzH3JSdJm0ti7LQ4/PKkOIopizapJEF6FSxUAvsVZ4M21rfGhlP L2j5n8ArhRpJwxCPYXmS1cGgqLZe1XJ7KeuJtUyXcZtCdSTlVQ== X-Google-Smtp-Source: AGHT+IFrehgOLMbed9uig3OTeGSjlPqjuMsCoQseTfnmiFR6sK8ZphVohd1A1KsFSDysEGZHH8pxGg== X-Received: by 2002:a17:90b:1d06:b0:28c:acc4:ff98 with SMTP id on6-20020a17090b1d0600b0028cacc4ff98mr1876483pjb.40.1705099531050; Fri, 12 Jan 2024 14:45:31 -0800 (PST) Received: from ?IPV6:2001:8004:2728:2ad6:e985:c1c8:a4fc:508? ([2001:8004:2728:2ad6:e985:c1c8:a4fc:508]) by smtp.gmail.com with ESMTPSA id nd15-20020a17090b4ccf00b0028e2827c8d1sm67927pjb.35.2024.01.12.14.45.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jan 2024 14:45:30 -0800 (PST) Message-ID: Date: Sat, 13 Jan 2024 09:45:22 +1100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb' in MAXSZ() Content-Language: en-US To: Daniel Henrique Barboza , qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, max.chou@sifive.com References: <20240112213812.173521-1-dbarboza@ventanamicro.com> <20240112213812.173521-11-dbarboza@ventanamicro.com> From: Richard Henderson In-Reply-To: <20240112213812.173521-11-dbarboza@ventanamicro.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 1/13/24 08:38, Daniel Henrique Barboza wrote: > MAXSZ() returns the value in bytes. Now that we have access to vlenb > we don't need to compensate with a '-3' in the scale to use 'vlen'. > > MAXSZ() now works as follows: > > LMUL lmul=scale MAXSZ (vlenb >> -scale) > 1 0 vlenb > 2 1 vlenb << 1 > 4 2 vlenb << 2 > 8 3 vlenb << 3 Um, what? > static inline uint32_t MAXSZ(DisasContext *s) > { > - int scale = s->lmul - 3; > - return s->cfg_ptr->vlen >> -scale; > + return s->cfg_ptr->vlenb >> -s->lmul; There's no left-shift here, either before or after. Bug? r~