From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
qemu-stable@nongnu.org
Cc: pbonzini@redhat.com, dgilbert@redhat.com, quintela@redhat.com,
famz@redhat.com, stefanha@redhat.com, den@openvz.org,
peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/2] nbd/client: fix nbd_negotiate_simple_meta_context
Date: Fri, 27 Apr 2018 10:20:11 -0500 [thread overview]
Message-ID: <fda2fb9a-e627-4627-b659-fc3854a8cbc6@redhat.com> (raw)
In-Reply-To: <20180427142002.21930-2-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On 04/27/2018 09:20 AM, Vladimir Sementsov-Ogievskiy wrote:
> Initialize received variable. Otherwise, is is possible for server to
> answer without any contexts, but we will set context_id to something
> random (received_id is not initialized too) and return 1, which is
> wrong.
>
> To solve it, just initialize received to false. Initialize received_id
> too, just to make all possible checkers happy.
>
> But was introduced in 78a33ab58782efdb206de14 "nbd: BLOCK_STATUS for
s/But/Bug/
> standard get_block_status function: client part" with the whole
> function.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> nbd/client.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2018-04-27 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 14:20 [Qemu-devel] [PATCH 0/2] fix coverity bugs Vladimir Sementsov-Ogievskiy
2018-04-27 14:20 ` [Qemu-devel] [PATCH 1/2] nbd/client: fix nbd_negotiate_simple_meta_context Vladimir Sementsov-Ogievskiy
2018-04-27 15:20 ` Eric Blake [this message]
2018-04-27 14:20 ` [Qemu-devel] [PATCH 2/2] migration/block-dirty-bitmap: fix memory leak in dirty_bitmap_load_bits Vladimir Sementsov-Ogievskiy
2018-04-27 15:19 ` [Qemu-devel] [PATCH 0/2] fix coverity bugs Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fda2fb9a-e627-4627-b659-fc3854a8cbc6@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).