qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>,
	qemu-stable@nongnu.org, Mark Kanda <mark.kanda@oracle.com>
Subject: Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events"
Date: Wed, 5 Jul 2023 09:51:24 +0200	[thread overview]
Message-ID: <fdaeb719-a061-6838-8075-f5ffd6dc856a@redhat.com> (raw)
In-Reply-To: <20230705071523.15496-1-sgarzare@redhat.com>

On 05/07/2023 09.15, Stefano Garzarella wrote:
> This reverts commit 8cc5583abe6419e7faaebc9fbd109f34f4c850f2.
> 
> That commit causes several problems in Linux as described in the BZ.
> In particular, after a while, other devices on the bus are no longer
> usable even if those devices are not affected by the hotunplug.
> This may be a problem in Linux, but we have not been able to identify
> it so far. So better to revert this patch until we find a solution.
> 
> Also, Oracle, which initially proposed this patch for a problem with
> Solaris, seems to have already reversed it downstream:
>      https://linux.oracle.com/errata/ELSA-2023-12065.html
> 
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2176702
> Cc: qemu-stable@nongnu.org
> Cc: Mark Kanda <mark.kanda@oracle.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>   include/hw/scsi/scsi.h |  1 -
>   hw/scsi/scsi-bus.c     | 18 ------------------
>   hw/scsi/virtio-scsi.c  |  2 --
>   3 files changed, 21 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2023-07-05  7:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05  7:15 [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events" Stefano Garzarella
2023-07-05  7:51 ` Thomas Huth [this message]
2023-07-05 12:28 ` Mark Kanda
2023-07-05 12:36   ` Stefano Garzarella
2023-07-07 15:57     ` Mark Kanda
2023-07-11  8:12       ` Stefano Garzarella
2023-07-10 19:40 ` Michael S. Tsirkin
2023-07-12  8:12   ` Paolo Bonzini
2023-08-03 20:03     ` Michael S. Tsirkin
2023-07-11 17:06 ` Stefano Garzarella
2023-07-11 17:41   ` Stefan Hajnoczi
2023-07-12  8:28     ` Stefano Garzarella
2023-07-12 13:40       ` Christoph Hellwig
2023-07-12 14:26         ` Paolo Bonzini
2023-07-11 20:21   ` Mike Christie
2023-07-12  8:06     ` Paolo Bonzini
2023-07-12 10:14       ` Stefano Garzarella
2023-07-12 14:20         ` Stefano Garzarella
2023-07-12  8:35   ` Paolo Bonzini
2023-07-12 10:24     ` Stefano Garzarella
2023-08-03 19:36 ` Michael S. Tsirkin
2023-08-03 19:56   ` Michael S. Tsirkin
2023-08-03 20:02 ` Michael S. Tsirkin
2023-08-03 21:26   ` Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdaeb719-a061-6838-8075-f5ffd6dc856a@redhat.com \
    --to=thuth@redhat.com \
    --cc=fam@euphon.net \
    --cc=mark.kanda@oracle.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=sgarzare@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).