From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: Taylor Simpson <tsimpson@quicinc.com>,
Riku Voipio <riku.voipio@iki.fi>,
Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2 1/4] scripts: add a script to generate syscall_nr.h
Date: Sun, 15 Mar 2020 16:13:14 -0700 [thread overview]
Message-ID: <fdc0622c-fdf7-a39c-cf76-14dd2dd3ccfd@linaro.org> (raw)
In-Reply-To: <20200314113922.233353-2-laurent@vivier.eu>
On 3/14/20 4:39 AM, Laurent Vivier wrote:
> +qemu_arch()
> +{
> + case "$1" in
> + arm64)
> + echo "aarch64"
> + ;;
> + *)
> + upper "$1"
> + ;;
> + esac
> +}
I think you can drop the upper here. That distinction is confusing. Anyway,
it's only use applies upper again.
With that,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-03-15 23:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 11:39 [PATCH v2 0/4] linux-user: generate syscall_nr.h from linux unistd.h Laurent Vivier
2020-03-14 11:39 ` [PATCH v2 1/4] scripts: add a script to generate syscall_nr.h Laurent Vivier
2020-03-15 23:13 ` Richard Henderson [this message]
2020-03-14 11:39 ` [PATCH v2 2/4] linux-user, aarch64: sync syscall numbers with kernel v5.5 Laurent Vivier
2020-03-15 23:03 ` Richard Henderson
2020-03-14 11:39 ` [PATCH v2 3/4] linux-user, nios2: " Laurent Vivier
2020-03-14 11:39 ` [PATCH v2 4/4] linux-user, openrisc: " Laurent Vivier
2020-03-15 23:14 ` Richard Henderson
2020-03-14 12:16 ` [PATCH v2 0/4] linux-user: generate syscall_nr.h from linux unistd.h no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdc0622c-fdf7-a39c-cf76-14dd2dd3ccfd@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).