qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>, Cleber Rosa <crosa@redhat.com>
Subject: Re: [PATCH] meson: Re-enable the possibility to run "make check SPEED=slow"
Date: Thu, 18 Feb 2021 19:01:05 +0100	[thread overview]
Message-ID: <fdc4d6ef-1a9b-ccac-9f86-588bc3fc3c1a@redhat.com> (raw)
In-Reply-To: <20210218172313.2217440-1-thuth@redhat.com>

On 18/02/21 18:23, Thomas Huth wrote:
> "make check SPEED=slow" got lost in the conversion of the build
> system to meson - the tests were always running in "quick" mode.
> Fix it by passing the "-m" parameter to the test harness at the
> right spot in scripts/mtest2make.py.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   scripts/mtest2make.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/mtest2make.py b/scripts/mtest2make.py
> index cbbcba100d..ee072c0502 100644
> --- a/scripts/mtest2make.py
> +++ b/scripts/mtest2make.py
> @@ -21,7 +21,7 @@ def __init__(self):
>   SPEED = quick
>   
>   # $1 = environment, $2 = test command, $3 = test name, $4 = dir
> -.test-human-tap = $1 $(if $4,(cd $4 && $2),$2) < /dev/null | ./scripts/tap-driver.pl --test-name="$3" $(if $(V),,--show-failures-only)
> +.test-human-tap = $1 $(if $4,(cd $4 && $2),$2) -m $(SPEED) < /dev/null | ./scripts/tap-driver.pl --test-name="$3" $(if $(V),,--show-failures-only)
>   .test-human-exitcode = $1 $(PYTHON) scripts/test-driver.py $(if $4,-C$4) $(if $(V),--verbose) -- $2 < /dev/null
>   .test-tap-tap = $1 $(if $4,(cd $4 && $2),$2) < /dev/null | sed "s/^[a-z][a-z]* [0-9]*/& $3/" || true
>   .test-tap-exitcode = printf "%s\\n" 1..1 "`$1 $(if $4,(cd $4 && $2),$2) < /dev/null > /dev/null || echo "not "`ok 1 $3"
> 

This is one way to do it, but it will be lost again when switching to 
"meson test".

Go ahead and commit it, I'll figure out something before switching.

Paolo



      parent reply	other threads:[~2021-02-18 18:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18 17:23 [PATCH] meson: Re-enable the possibility to run "make check SPEED=slow" Thomas Huth
2021-02-18 17:57 ` no-reply
2021-02-18 18:01 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fdc4d6ef-1a9b-ccac-9f86-588bc3fc3c1a@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=crosa@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).