From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org
Cc: ppandit@redhat.com
Subject: Re: [PATCH 3/6] dp8393x: switch to use qemu_receive_packet() for loopback packet
Date: Thu, 25 Feb 2021 15:36:38 +0100 [thread overview]
Message-ID: <fdd95814-c3d9-3c93-466a-5846da8e10e5@redhat.com> (raw)
In-Reply-To: <70f3456c-1f3b-8a14-8c51-a0b7dff5f048@weilnetz.de>
On 2/24/21 7:13 AM, Stefan Weil wrote:
> Am 24.02.21 um 06:53 schrieb Jason Wang:
>
>> This patch switches to use qemu_receive_packet() which can detect
>> reentrancy and return early.
>>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>> hw/net/dp8393x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c
>> index 205c0decc5..019d4fe435 100644
>> --- a/hw/net/dp8393x.c
>> +++ b/hw/net/dp8393x.c
>> @@ -506,7 +506,7 @@ static void
>> dp8393x_do_transmit_packets(dp8393xState *s)
>> s->regs[SONIC_TCR] |= SONIC_TCR_CRSL;
>> if (nc->info->can_receive(nc)) {
>> s->loopback_packet = 1;
>> - nc->info->receive(nc, s->tx_buffer, tx_len);
>> + qemu_receice_packet(nc, s->tx_buffer, tx_Len);
>
>
> Did you test compilation of that code? It looks like a typo ...
With typo fixed:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-02-25 14:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 5:53 [PATCH 0/6] Detect reentrant RX casue by loopback Jason Wang
2021-02-24 5:53 ` [PATCH 1/6] net: introduce qemu_receive_packet() Jason Wang
2021-02-24 10:11 ` Philippe Mathieu-Daudé
2021-02-24 13:17 ` Jason Wang
2021-02-24 13:43 ` Philippe Mathieu-Daudé
2021-02-25 14:01 ` P J P
2021-02-25 16:28 ` Alexander Bulekov
2021-02-25 16:29 ` Alexander Bulekov
2021-02-26 18:14 ` [QEMU-SECURITY] " P J P
2021-02-26 18:53 ` Alexander Bulekov
2021-02-25 14:31 ` Philippe Mathieu-Daudé
2021-02-24 5:53 ` [PATCH 2/6] e1000: switch to use qemu_receive_packet() for loopback Jason Wang
2021-02-25 14:34 ` Philippe Mathieu-Daudé
2021-02-24 5:53 ` [PATCH 3/6] dp8393x: switch to use qemu_receive_packet() for loopback packet Jason Wang
2021-02-24 6:13 ` Stefan Weil
2021-02-25 14:36 ` Philippe Mathieu-Daudé [this message]
2021-02-25 14:42 ` Stefan Weil
2021-02-26 7:04 ` Jason Wang
2021-02-24 5:53 ` [PATCH 4/6] msf2-mac: switch to use qemu_receive_packet() for loopback Jason Wang
2021-02-25 14:34 ` Philippe Mathieu-Daudé
2021-02-24 5:54 ` [PATCH 5/6] sungem: " Jason Wang
2021-02-25 14:35 ` Philippe Mathieu-Daudé
2021-02-24 5:54 ` [PATCH 6/6] tx_pkt: switch to use qemu_receive_packet_iov() " Jason Wang
2021-02-25 14:35 ` Philippe Mathieu-Daudé
2021-02-24 6:03 ` [PATCH 0/6] Detect reentrant RX casue by loopback no-reply
2021-02-26 18:47 ` [PATCH] rtl8193: switch to use qemu_receive_packet() for loopback Alexander Bulekov
2021-03-01 7:14 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdd95814-c3d9-3c93-466a-5846da8e10e5@redhat.com \
--to=philmd@redhat.com \
--cc=jasowang@redhat.com \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).