From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b59BI-0003Vb-W7 for qemu-devel@nongnu.org; Tue, 24 May 2016 06:03:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b59BF-0004LO-RH for qemu-devel@nongnu.org; Tue, 24 May 2016 06:03:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b59BF-0004LK-MB for qemu-devel@nongnu.org; Tue, 24 May 2016 06:03:17 -0400 References: <1463671442-15631-1-git-send-email-minyard@acm.org> <1463671442-15631-6-git-send-email-minyard@acm.org> <20160520115344.29b1a24d@nial.brq.redhat.com> <57435921.1090909@mvista.com> From: Paolo Bonzini Message-ID: Date: Tue, 24 May 2016 12:03:10 +0200 MIME-Version: 1.0 In-Reply-To: <57435921.1090909@mvista.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 5/6] acpi: Add IPMI table entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Minyard , Igor Mammedov , minyard@acm.org Cc: "Michael S . Tsirkin" , qemu-devel@nongnu.org On 23/05/2016 21:25, Corey Minyard wrote: >> Don't overuse stubs. The stubs library is mostly to share code between >> QEMU and the tools. What Corey did is more similar to what hw/ already >> does in other places. > > Should I change it back? Yes, please. Sorry. Thanks, Paolo