From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D1BC33CB1 for ; Tue, 14 Jan 2020 13:48:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7461924679 for ; Tue, 14 Jan 2020 13:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NBeMQX7u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7461924679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irMYO-0007xc-Et for qemu-devel@archiver.kernel.org; Tue, 14 Jan 2020 08:48:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50308) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irMWM-00079G-Ui for qemu-devel@nongnu.org; Tue, 14 Jan 2020 08:46:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irMWJ-0006CH-1x for qemu-devel@nongnu.org; Tue, 14 Jan 2020 08:46:14 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:57651 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1irMWI-0006Bs-Tp for qemu-devel@nongnu.org; Tue, 14 Jan 2020 08:46:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579009570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=h0uUDPKfy6lPd1yUa7ZPrHsZ2YDz7lJ2HCtnQC9x3oM=; b=NBeMQX7uigGPmlcOLTjWfQG+5NAD41Axrfidwt/S6koj9LpcBhV+U2/tqTid1hPgDwUhMy b3kTVIfeOHyB64mctnLIfyzjJnPP+RRHSTFqXfU8cIGr31HcNQnjtiPLtI7S0gLP2QYcWv 9dApoCFH5G8KolyBf57F9eOk27ZFjto= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-dSwkdFi5OxKoGg2Saww2bw-1; Tue, 14 Jan 2020 08:46:06 -0500 X-MC-Unique: dSwkdFi5OxKoGg2Saww2bw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 67684107ACC5; Tue, 14 Jan 2020 13:46:05 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.36.118.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D862A5C219; Tue, 14 Jan 2020 13:46:02 +0000 (UTC) Subject: Re: [PATCH v2 2/4] qcow2: Don't round the L1 table allocation up to the sector size To: Alberto Garcia , qemu-devel@nongnu.org References: From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Tue, 14 Jan 2020 14:46:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CehUbI3wb9wmgWD0jMijMkwYg7vNJz3M0" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Nir Soffer , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CehUbI3wb9wmgWD0jMijMkwYg7vNJz3M0 Content-Type: multipart/mixed; boundary="4oCgNFzxdeLvySTItYv8e7BhPk1FuO1MQ" --4oCgNFzxdeLvySTItYv8e7BhPk1FuO1MQ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 09.01.20 20:13, Alberto Garcia wrote: > The L1 table is read from disk using the byte-based bdrv_pread() and > is never accessed beyond its last element, so there's no need to > allocate more memory than that. >=20 > Signed-off-by: Alberto Garcia > --- > block/qcow2-cluster.c | 5 ++--- > block/qcow2-refcount.c | 2 +- > block/qcow2-snapshot.c | 3 +-- > block/qcow2.c | 2 +- > 4 files changed, 5 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz --4oCgNFzxdeLvySTItYv8e7BhPk1FuO1MQ-- --CehUbI3wb9wmgWD0jMijMkwYg7vNJz3M0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl4dxhkACgkQ9AfbAGHV z0AaaQf/WRP+gIpqeWylxFeGTxIhHGbynEHeh6LLHFzacu4GGbgmvB324PVBglHe 9GG68MvibMMS8rdM2Lbho0P3Jqo9ju6LTGSHHxMgvhBSWxcLXcWMxVbUWYfaA4hy s3RE/GKznujDLwS3yq1IY75ybFnxzNCSrvF6t1JSpM6UYfcvYzh/SJV7gMvaonR4 Y5o0s7gs7VQPcRrYuBKDen44W12RG6gmPWY5neST5wI1p9HyCODaBTI8WacG7Nti GZYTWLvt3AmlQhWocwup1bOiRs/jT5DCmrVWuigHHXe2uuIDiWj4+FZsKbhaKXLd JYqzwTPlzYTW4nQwPy5MwfI5U9v3Rw== =Anar -----END PGP SIGNATURE----- --CehUbI3wb9wmgWD0jMijMkwYg7vNJz3M0--