From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egWh8-0000M9-NJ for qemu-devel@nongnu.org; Tue, 30 Jan 2018 09:15:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egWh3-0008Qa-PH for qemu-devel@nongnu.org; Tue, 30 Jan 2018 09:15:30 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:34831) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egWh3-0008Px-GX for qemu-devel@nongnu.org; Tue, 30 Jan 2018 09:15:25 -0500 Received: by mail-qt0-f194.google.com with SMTP id g14so17388937qti.2 for ; Tue, 30 Jan 2018 06:15:24 -0800 (PST) References: <201801232242.31243.pisa@cmp.felk.cvut.cz> <201801252233.45477.pisa@cmp.felk.cvut.cz> From: Paolo Bonzini Message-ID: Date: Tue, 30 Jan 2018 15:15:22 +0100 MIME-Version: 1.0 In-Reply-To: <201801252233.45477.pisa@cmp.felk.cvut.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 0/7] CAN bus support for QEMU (SJA1000 PCI so far) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Pisa Cc: Marek Vasut , Oliver Hartkopp , Stefan Hajnoczi , Deniz Eren , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Oleksij Rempel , Konrad Frederic , Jan Kiszka , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= On 25/01/2018 22:33, Pavel Pisa wrote: > Hello Paolo, > > thanks for suggestions. I understand and fully agree with your > request to switch to QOM. I have succeed with that for CAN devices > some time ago. It worth to be done for the rest of the objects > but I fear that I do not find time to complete QOMification > in reasonable future. Contributions/suggestions from other > are welcomed. I can look for students for GSoC at our university > or under other funding. Please take a look at branch can-pci-qom of github.com/bonzini/qemu.git. Apart from QOMification of the backend include, I simplified the IRQ handling in can_kvaser_pci (fixing bugs too I think), and removed an unnecessary mutex. I also moved the files to net/can and hw/net/can so that in the future Jason (networking maintainer) can take care of pull requests. I might have broken something, and the top commit in particular is completely untested. Paolo