From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Yang Zhong <yang.zhong@intel.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, eblake@redhat.com, seanjc@google.com
Subject: Re: [PATCH 6/7] monitor: Fix coredump issue in non-x86 platform
Date: Wed, 8 Sep 2021 10:53:48 +0200 [thread overview]
Message-ID: <fe225574-3b4c-1969-6ed0-3a9103608c12@redhat.com> (raw)
In-Reply-To: <20210908081937.77254-7-yang.zhong@intel.com>
On 9/8/21 10:19 AM, Yang Zhong wrote:
> The monitor will coredump if we use 'info sgx' in the '-machine none' or
> other non-x86 platform, add the sgx_enabled bool variable to avoid this
> coredump issue.
But this code is only built for x86...
>
> ./qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -machine none,accel=kvm -monitor stdio
> QEMU 6.1.50 monitor - type 'help' for more information
> (qemu) info sgx
> /home/vmm/project/upstream/9-8/qemu/include/hw/i386/x86.h:93:X86_MACHINE: Object 0x5615d71a6fd0 is not an instance of type x86-machine
> Aborted (core dumped)
Paolo suggested on IRC to use object_class_dynamic_cast().
>
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> ---
> hw/i386/sgx.c | 32 +++++++++++++++++++-------------
> 1 file changed, 19 insertions(+), 13 deletions(-)
next prev parent reply other threads:[~2021-09-08 8:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 8:19 [PATCH 0/7] The HMP/QMP interfaces in Qemu SGX Yang Zhong
2021-09-08 8:19 ` [PATCH 1/7] qmp: Add query-sgx command Yang Zhong
2021-09-08 8:19 ` [PATCH 2/7] hmp: Add 'info sgx' command Yang Zhong
2021-09-08 8:19 ` [PATCH 3/7] i386: Add sgx_get_info() interface Yang Zhong
2021-09-08 8:32 ` Philippe Mathieu-Daudé
2021-09-09 2:20 ` Yang Zhong
2021-09-08 8:55 ` Paolo Bonzini
2021-09-09 7:05 ` Yang Zhong
2021-09-08 8:19 ` [PATCH 4/7] bitops: Support 32 and 64 bit mask macro Yang Zhong
2021-09-08 8:34 ` Philippe Mathieu-Daudé
2021-09-09 2:04 ` Yang Zhong
2021-09-08 8:19 ` [PATCH 5/7] qmp: Add the qmp_query_sgx_capabilities() Yang Zhong
2021-09-08 8:38 ` Philippe Mathieu-Daudé
2021-09-09 2:51 ` Yang Zhong
2021-09-09 9:36 ` Philippe Mathieu-Daudé
2021-09-09 12:06 ` Yang Zhong
2021-09-09 13:25 ` Philippe Mathieu-Daudé
2021-09-08 8:19 ` [PATCH 6/7] monitor: Fix coredump issue in non-x86 platform Yang Zhong
2021-09-08 8:53 ` Philippe Mathieu-Daudé [this message]
2021-09-08 8:54 ` Paolo Bonzini
2021-09-09 6:48 ` Yang Zhong
2021-09-08 8:19 ` [PATCH 7/7] pc: Cleanup the SGX definitions Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe225574-3b4c-1969-6ed0-3a9103608c12@redhat.com \
--to=philmd@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seanjc@google.com \
--cc=yang.zhong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).