From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Konstantin Kostiuk <kkostiuk@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Yan Vugenfirer" <yvugenfi@redhat.com>
Subject: Re: [PATCH 2/4] QGA VSS: Replace 'fprintf(stderr' with PRINT_DEBUG
Date: Wed, 5 Jul 2023 22:36:21 +0200 [thread overview]
Message-ID: <fe2afd5c-fc4b-f1f5-017b-a33cb9bfe894@linaro.org> (raw)
In-Reply-To: <20230705141205.525776-3-kkostiuk@redhat.com>
On 5/7/23 16:12, Konstantin Kostiuk wrote:
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
> qga/vss-win32/install.cpp | 13 +++++++------
> qga/vss-win32/requester.cpp | 9 +++++----
> 2 files changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp
> index ff93b08a9e..c10a397e51 100644
> --- a/qga/vss-win32/install.cpp
> +++ b/qga/vss-win32/install.cpp
> @@ -13,6 +13,7 @@
> #include "qemu/osdep.h"
>
> #include "vss-common.h"
> +#include "vss-debug.h"
> #ifdef HAVE_VSS_SDK
> #include <vscoordint.h>
> #else
> @@ -54,7 +55,7 @@ void errmsg(DWORD err, const char *text)
> FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
> NULL, err, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
> (char *)&msg, 0, NULL);
> - fprintf(stderr, "%.*s. (Error: %lx) %s\n", len, text, err, msg);
> + PRINT_DEBUG("%.*s. (Error: %lx) %s\n", len, text, err, msg);
PRINT_DEBUG() ends calling fprintf(stderr)...
next prev parent reply other threads:[~2023-07-05 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 14:12 [PATCH 0/4] QGA VSS Logging Konstantin Kostiuk
2023-07-05 14:12 ` [PATCH 1/4] QGA VSS: Add wrapper to send log to debugger and stderr Konstantin Kostiuk
2023-07-05 20:35 ` Philippe Mathieu-Daudé
2023-07-06 7:54 ` Konstantin Kostiuk
2023-07-06 10:01 ` Philippe Mathieu-Daudé
2023-07-06 10:58 ` Konstantin Kostiuk
2023-07-06 16:48 ` Philippe Mathieu-Daudé
2023-07-05 14:12 ` [PATCH 2/4] QGA VSS: Replace 'fprintf(stderr' with PRINT_DEBUG Konstantin Kostiuk
2023-07-05 20:36 ` Philippe Mathieu-Daudé [this message]
2023-07-06 8:36 ` Konstantin Kostiuk
2023-07-05 14:12 ` [PATCH 3/4] QGA VSS: Print error in err_set Konstantin Kostiuk
2023-07-05 14:12 ` [PATCH 4/4] QGA VSS: Add log in functions begin/end Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe2afd5c-fc4b-f1f5-017b-a33cb9bfe894@linaro.org \
--to=philmd@linaro.org \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).