From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 860CCC61DA4 for ; Mon, 6 Feb 2023 11:18:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOzVo-0002op-6T; Mon, 06 Feb 2023 06:18:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOzVm-0002o2-A6 for qemu-devel@nongnu.org; Mon, 06 Feb 2023 06:18:14 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOzVk-0002U0-FW for qemu-devel@nongnu.org; Mon, 06 Feb 2023 06:18:14 -0500 Received: by mail-wm1-x32b.google.com with SMTP id n13so8387253wmr.4 for ; Mon, 06 Feb 2023 03:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kp9wWGYlisByX/SGntQzjUtEe66S3uULw2QfqrHXT7Y=; b=ebcZGJD2m9/bvQ42+qEcfKHcpJOBW9XqvIjdQOB2tPtL+H6VlvJKQME/2Y8szQADTh DvA9aNTrNk3xginMurohb1iC3GTrHHqd0Hng9FCpcXnlDU1ZOfb9z8FKSbpwGAHXKNvE NPEnIBlOTrpffgXvXk4dxAm5HbPF1+8/kjd8DV0JmcYm63AVSgDGnHOZI91Dp9byhYSH 01l62sRm4j3kZs3G/HYefVL1FXqdAqyumx7FkUY7L3iuF9aqzAQnvY4BIYO03b7PhTJ8 e0h8NnJjAgy9MUMQZir6EkT2PiiZQ45OXDPogVldQSlUbyowTEpD7E/sK08VMDIkPMKE AFHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kp9wWGYlisByX/SGntQzjUtEe66S3uULw2QfqrHXT7Y=; b=A9w2y+XJEkikLGEKOHKelxCtTLNVsDcBWBd6S54p5KRyFZcKaWNRq0MyRm198Blcgp InU2QoT8MtGBJSf1WPwt0JDNL+L5GsiQEju966wQXYEO9zTWEwUfeJ87KMzJsjfBVvyj d6qw7faxK9jxJTYxefrRbhBXXXJddaXEHzf51iRE8Oc6P5r51Pk20XzNpklIQKm+3fJI 60CFczEaKzYOGsa/bk7Mc/gRQ4O7GrcH9X/1BnvGEQGCVzyCzun3qjnIwyZwMq0ill22 5vKiFi985D+Qn5LMyHvXXLX74VDLpmXW16x9Uymy8K7EPApVPkts+D4O1+zKeurFiaKw Jftw== X-Gm-Message-State: AO0yUKXBQnKy3c+TJSwrBIuhcAxxET60aMUMaRDAvoNME4k64LmB0a7M lISy1Q+L/TeJy8EJKnqXF+P+Eg== X-Google-Smtp-Source: AK7set+RlM0y7XO4ihlwYduFQlG7u9sLgngAQVswrPlesHcMjiwdArGO34Jz2hyZoOsI82nt5q0t+A== X-Received: by 2002:a05:600c:43c5:b0:3dc:5674:66e6 with SMTP id f5-20020a05600c43c500b003dc567466e6mr19029897wmn.25.1675682289910; Mon, 06 Feb 2023 03:18:09 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id he7-20020a05600c540700b003df5be8987esm13820781wmb.20.2023.02.06.03.18.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Feb 2023 03:18:08 -0800 (PST) Message-ID: Date: Mon, 6 Feb 2023 12:18:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI Content-Language: en-US To: Andrea Bolognani , Sunil V L Cc: Palmer Dabbelt , Alistair Francis , Bin Meng , qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Andrew Jones , Anup Patel , Atish Kumar Patra , Ani Sinha , "Michael S. Tsirkin" , Markus Armbruster , Igor Mammedov , Gerd Hoffmann , Thomas Huth , Bernhard Beschow References: <20230202045223.2594627-1-sunilvl@ventanamicro.com> <20230202045223.2594627-3-sunilvl@ventanamicro.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.149, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/2/23 11:54, Andrea Bolognani wrote: > On Thu, Feb 02, 2023 at 10:22:15AM +0530, Sunil V L wrote: >> + object_class_property_add(oc, "acpi", "OnOffAuto", >> + virt_get_acpi, virt_set_acpi, >> + NULL, NULL); >> + object_class_property_set_description(oc, "acpi", >> + "Enable ACPI"); > > The way this works on other architectures (x86_64, aarch64) is that > you get ACPI by default and can use -no-acpi to disable it if > desired. Can we have the same on RISC-V, for consistency? -no-acpi rather seems a x86-specific hack for the ISA PC machine, and has a high maintenance cost / burden. If hardware provides ACPI support, QEMU should expose it to the guest. Actually, what is the value added by '-no-acpi'?