From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51979)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1biKyQ-0006PW-Q6
	for qemu-devel@nongnu.org; Fri, 09 Sep 2016 08:32:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lvivier@redhat.com>) id 1biKyN-0002FB-MY
	for qemu-devel@nongnu.org; Fri, 09 Sep 2016 08:32:02 -0400
References: <1473167877-2545-1-git-send-email-lvivier@redhat.com>
	<1473167877-2545-3-git-send-email-lvivier@redhat.com>
	<20160908020423.GD3883@voom.fritz.box>
	<19b24b76-5650-74de-6870-f6a8bc3f5e12@redhat.com>
	<20160909142545.4876b85e@bahia>
From: Laurent Vivier <lvivier@redhat.com>
Message-ID: <fe46601c-c28e-b9c4-a910-6d1c32c9624b@redhat.com>
Date: Fri, 9 Sep 2016 14:31:55 +0200
MIME-Version: 1.0
In-Reply-To: <20160909142545.4876b85e@bahia>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 2/3] tests: make
 pc_alloc_init/init_flags/uninit generic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <groug@kaod.org>
Cc: David Gibson <david@gibson.dropbear.id.au>, thuth@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org



On 09/09/2016 14:25, Greg Kurz wrote:
> On Thu, 8 Sep 2016 09:50:31 +0200
> Laurent Vivier <lvivier@redhat.com> wrote:
> 
>> On 08/09/2016 04:04, David Gibson wrote:
>>> On Tue, Sep 06, 2016 at 03:17:56PM +0200, Laurent Vivier wrote:  
>>>> And add support for ppc64.
>>>>
>>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>  
>>>
>>> Some of my coments may be obsoleted by the discussion with Greg.
>>>   
>>>> ---
>>>> v2:
>>>> - remove useless parenthesis, inline
>> [...]
>>>> +
>>>> +QGuestAllocator *machine_alloc_init(void)
>>>> +{
>>>> +    const char *arch = qtest_get_arch();  
>>>
>>> Maybe we need to add a qtest_get_machine_type().  
>>
>> I'm working on that...
>>
> 
> The problem is that qtest only knows about archs, based on $(TARGETS).
> Maybe the machine type could be the default one for a given arch ?

Once the machine is started we can use QMP[1] to ask the machine type
(for instance, "pseries-2.7-machine").

So what we could do is a generic qtest_machine_vboot() which ask the
machine type and configure the qtest framework accordingly.

Laurent
[1] { 'execute': 'qom-get', 'arguments': { 'path': '/machine',
'property': 'type' } }