From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmjP2-000470-CJ for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:25:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmjOy-0004RA-4B for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:25:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmjOx-0004Qt-QG for qemu-devel@nongnu.org; Wed, 21 Sep 2016 11:25:36 -0400 References: From: Paolo Bonzini Message-ID: Date: Wed, 21 Sep 2016 17:25:31 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] Produce better termination message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik , qemu-devel@nongnu.org Cc: armbru@redhat.com, peter.maydell@linaro.org, eblake@redhat.com On 21/09/2016 13:26, Michal Privoznik wrote: > v2 of: > > http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg04710.html > > The checkpatch.pl shows the following error for 1/2: > > ERROR: architecture specific defines should be avoided > #63: FILE: util/oslib-posix.c:441: > +#if defined(__FreeBSD__) > > But I guess we should ignore the error, since in this case we > want OS specific code. Yeah, this should probably be degraded to WARN. > diff to v1: > - Reworked 1/2 to follow Paolo's review suggestions > - Produce "()" instead of "()" in 2/2 in case > the PID is unknown. > > Michal Privoznik (2): > util: Introduce qemu_get_pid_name > qemu_kill_report: Report PID name too > > include/qemu/osdep.h | 10 ++++++++++ > util/oslib-posix.c | 37 +++++++++++++++++++++++++++++++++++++ > util/oslib-win32.c | 7 +++++++ > vl.c | 8 ++++++-- > 4 files changed, 60 insertions(+), 2 deletions(-) > Looks good, thanks. Paolo