qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: ardb@kernel.org, berrange@redhat.com, qemu-ppc@nongnu.org,
	qemu-arm@nongnu.org, qemu-riscv@nongnu.org, pbonzini@redhat.com
Subject: Re: [PATCH v2 15/38] target/ppc: Use aesdec_ISB_ISR_AK
Date: Mon, 12 Jun 2023 10:27:55 -0300	[thread overview]
Message-ID: <fe568cb8-b48f-d72e-a3ff-a5bd32662566@gmail.com> (raw)
In-Reply-To: <20230609022401.684157-16-richard.henderson@linaro.org>



On 6/8/23 23:23, Richard Henderson wrote:
> This implements the VNCIPHERLAST instruction.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   target/ppc/int_helper.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c
> index 34257e9d76..15f07fca2b 100644
> --- a/target/ppc/int_helper.c
> +++ b/target/ppc/int_helper.c
> @@ -2973,13 +2973,7 @@ void helper_vncipher(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
>   
>   void helper_vncipherlast(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)
>   {
> -    ppc_avr_t result;
> -    int i;
> -
> -    VECTOR_FOR_INORDER_I(i, u8) {
> -        result.VsrB(i) = b->VsrB(i) ^ (AES_isbox[a->VsrB(AES_ishifts[i])]);
> -    }
> -    *r = result;
> +    aesdec_ISB_ISR_AK((AESState *)r, (AESState *)a, (AESState *)b, true);
>   }
>   
>   void helper_vshasigmaw(ppc_avr_t *r,  ppc_avr_t *a, uint32_t st_six)


  reply	other threads:[~2023-06-12 13:28 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09  2:23 [PATCH v2 00/38] crypto: Provide aes-round.h and host accel Richard Henderson
2023-06-09  2:23 ` [PATCH v2 01/38] tcg/ppc: Define _CALL_AIX for clang on ppc64(be) Richard Henderson
2023-06-12 13:25   ` Daniel Henrique Barboza
2023-06-09  2:23 ` [PATCH v2 02/38] util: Add cpuinfo-ppc.c Richard Henderson
2023-06-12 13:27   ` Daniel Henrique Barboza
2023-06-19 10:37   ` Philippe Mathieu-Daudé
2023-06-19 14:44     ` Richard Henderson
2023-06-09  2:23 ` [PATCH v2 03/38] tests/multiarch: Add test-aes Richard Henderson
2023-06-12 14:46   ` Alex Bennée
2023-06-14  3:40     ` Richard Henderson
2023-06-09  2:23 ` [PATCH v2 04/38] target/arm: Move aesmc and aesimc tables to crypto/aes.c Richard Henderson
2023-06-19 16:49   ` Daniel P. Berrangé
2023-06-09  2:23 ` [PATCH v2 05/38] crypto/aes: Add constants for ShiftRows, InvShiftRows Richard Henderson
2023-06-19 15:41   ` Daniel P. Berrangé
2023-06-29 10:21   ` Ard Biesheuvel
2023-06-29 11:58     ` Richard Henderson
2023-06-09  2:23 ` [PATCH v2 06/38] crypto: Add aesenc_SB_SR_AK Richard Henderson
2023-06-19 16:56   ` Daniel P. Berrangé
2023-06-19 17:05     ` Richard Henderson
2023-06-09  2:23 ` [PATCH v2 07/38] target/i386: Use aesenc_SB_SR_AK Richard Henderson
2023-06-19 10:43   ` Philippe Mathieu-Daudé
2023-06-19 10:45     ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 08/38] target/arm: Demultiplex AESE and AESMC Richard Henderson
2023-06-09  2:23 ` [PATCH v2 09/38] target/arm: Use aesenc_SB_SR_AK Richard Henderson
2023-06-09  2:23 ` [PATCH v2 10/38] target/ppc: " Richard Henderson
2023-06-12 13:26   ` Daniel Henrique Barboza
2023-06-19 10:47   ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 11/38] target/riscv: " Richard Henderson
2023-06-09  2:23 ` [PATCH v2 12/38] crypto: Add aesdec_ISB_ISR_AK Richard Henderson
2023-06-09  2:23 ` [PATCH v2 13/38] target/i386: Use aesdec_ISB_ISR_AK Richard Henderson
2023-06-19 10:51   ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 14/38] target/arm: " Richard Henderson
2023-06-09  2:23 ` [PATCH v2 15/38] target/ppc: " Richard Henderson
2023-06-12 13:27   ` Daniel Henrique Barboza [this message]
2023-06-19 10:51   ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 16/38] target/riscv: " Richard Henderson
2023-06-09  2:23 ` [PATCH v2 17/38] crypto: Add aesenc_MC Richard Henderson
2023-06-09  2:23 ` [PATCH v2 18/38] target/arm: Use aesenc_MC Richard Henderson
2023-06-09  2:23 ` [PATCH v2 19/38] crypto: Add aesdec_IMC Richard Henderson
2023-06-09  2:23 ` [PATCH v2 20/38] target/i386: Use aesdec_IMC Richard Henderson
2023-06-09  2:23 ` [PATCH v2 21/38] target/arm: " Richard Henderson
2023-06-09  2:23 ` [PATCH v2 22/38] target/riscv: " Richard Henderson
2023-06-09  2:23 ` [PATCH v2 23/38] crypto: Add aesenc_SB_SR_MC_AK Richard Henderson
2023-06-09  2:23 ` [PATCH v2 24/38] target/i386: Use aesenc_SB_SR_MC_AK Richard Henderson
2023-06-09  2:23 ` [PATCH v2 25/38] target/ppc: " Richard Henderson
2023-06-12 13:28   ` Daniel Henrique Barboza
2023-06-09  2:23 ` [PATCH v2 26/38] target/riscv: " Richard Henderson
2023-06-09  2:23 ` [PATCH v2 27/38] crypto: Add aesdec_ISB_ISR_IMC_AK Richard Henderson
2023-06-09  2:23 ` [PATCH v2 28/38] target/i386: Use aesdec_ISB_ISR_IMC_AK Richard Henderson
2023-06-09  2:23 ` [PATCH v2 29/38] target/riscv: " Richard Henderson
2023-06-09  2:23 ` [PATCH v2 30/38] crypto: Add aesdec_ISB_ISR_AK_IMC Richard Henderson
2023-06-19 13:59   ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 31/38] target/ppc: Use aesdec_ISB_ISR_AK_IMC Richard Henderson
2023-06-12 13:28   ` Daniel Henrique Barboza
2023-06-19 13:46   ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 32/38] crypto: Remove AES_shifts, AES_ishifts Richard Henderson
2023-06-19 13:45   ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 33/38] crypto: Implement aesdec_IMC with AES_imc_rot Richard Henderson
2023-06-20  5:09   ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 34/38] crypto: Remove AES_imc Richard Henderson
2023-06-19 13:19   ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 35/38] crypto: Unexport AES_*_rot, AES_TeN, AES_TdN Richard Henderson
2023-06-19 13:18   ` Philippe Mathieu-Daudé
2023-06-09  2:23 ` [PATCH v2 36/38] host/include/i386: Implement aes-round.h Richard Henderson
2023-06-09  2:24 ` [PATCH v2 37/38] host/include/aarch64: " Richard Henderson
2023-06-09  2:24 ` [PATCH v2 38/38] host/include/ppc: " Richard Henderson
2023-06-12 13:30   ` Daniel Henrique Barboza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe568cb8-b48f-d72e-a3ff-a5bd32662566@gmail.com \
    --to=danielhb413@gmail.com \
    --cc=ardb@kernel.org \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).