From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 151FDC433DF for ; Tue, 7 Jul 2020 09:11:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D38C3206DF for ; Tue, 7 Jul 2020 09:11:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AnvKSSSK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D38C3206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsjdG-0005tU-6Q for qemu-devel@archiver.kernel.org; Tue, 07 Jul 2020 05:11:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsjcY-0005Ai-05 for qemu-devel@nongnu.org; Tue, 07 Jul 2020 05:10:34 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:57680 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jsjcW-0007au-Aw for qemu-devel@nongnu.org; Tue, 07 Jul 2020 05:10:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594113031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cO3Re3qyBZgg2vmQy5jVbKaNty1fWrrsr1X+wd6exFo=; b=AnvKSSSK9VnwoqjHRQM6NZfUIwelJnRV6fRcj8utNm//QSU/LRGrSr1Z0hrfe2GpWm4mvg GNeGvLtEh/nkOQLZjooJrXlhr2HnuEqxmtIttTpyDxwwL9Sq25B2FrobeSoyJej7XqMCCG KtY23QCNC33nouRctBj1Zwu4DYwQauY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-491-kL_OGkcWOsehRrUa62C3uw-1; Tue, 07 Jul 2020 05:10:29 -0400 X-MC-Unique: kL_OGkcWOsehRrUa62C3uw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 69265800D5C; Tue, 7 Jul 2020 09:10:28 +0000 (UTC) Received: from starship (unknown [10.35.206.237]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B62C7166C; Tue, 7 Jul 2020 09:10:25 +0000 (UTC) Message-ID: Subject: Re: [PATCH 0/1] hw/block/nvme: fix assert on invalid irq vector From: Maxim Levitsky To: Kevin Wolf , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Date: Tue, 07 Jul 2020 12:10:24 +0300 In-Reply-To: <20200609153243.GE11003@linux.fritz.box> References: <20200609094508.32412-1-its@irrelevant.dk> <20200609114633.yvwtt6swb47l27yd@apples.localdomain> <20200609141425.GC11003@linux.fritz.box> <48537ee1-ed77-ffe6-66ba-d61838083069@redhat.com> <20200609153243.GE11003@linux.fritz.box> User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mlevitsk@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=mlevitsk@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 00:46:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-block@nongnu.org, Klaus Jensen , qemu-devel@nongnu.org, Max Reitz , Keith Busch , Klaus Jensen , Javier Gonzalez Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 2020-06-09 at 17:32 +0200, Kevin Wolf wrote: > Am 09.06.2020 um 16:18 hat Philippe Mathieu-Daudé geschrieben: > > On 6/9/20 4:14 PM, Kevin Wolf wrote: > > > Am 09.06.2020 um 13:46 hat Klaus Jensen geschrieben: > > > > On Jun 9 13:17, Philippe Mathieu-Daudé wrote: > > > > > On 6/9/20 11:45 AM, Klaus Jensen wrote: > > > > > > From: Klaus Jensen > > > > > > > > > > > > I goofed up with commit c09794fe40e3 ("hw/block/nvme: allow use of any > > > > > > valid msix vector"). > > > > > > > > > > Kevin, since your queue isn't merged, can you directly squash the fix? > > > > > > > > The commit (c09794fe40e3) can just be dropped without conflicts, but it > > > > leaves a use of n->params.num_queues in nvme_create_cq() which commit > > > > cde74bfd4b87 ("hw/block/nvme: add max_ioqpairs device parameter") must > > > > fix. > > > > > > Hm, so it seems this isn't easy to squash in without conflicts (and I > > > would have to rewrite the whole commit message), so I think it's better > > > to just apply the series on top. > > > > > > One problem with the commit message is that it references commit IDs > > > which aren't stable yet. Maybe it's best if I apply these patches, > > > manually fix up the commit ID references and then immediately do a pull > > > request so that they become stable. > > > > This is the friendlier way. > > > > Less friendly way is to drop Klaus's patches and ask him to respin. > > While this is a valid outcome, if we can avoid it it will save all of us > > review time. > > If Klaus wants to do that, fine with me. I'm just trying to find the > easiest solution for all of us. > > > > It would be good to have at least one review, though. > > > > Maxim catched this issue, I'd feel safer if he acks your pre-merge queue. > > Ok. Maxim, can you please review this series then? > > Kevin I am slowly getting through the heap of the patches trying to understand the current state of things. I will start reviewing all these patches today. Best regards, Maxim Levitsky