qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>
Subject: Re: [PATCH v2 0/2] build contrib/plugins using meson
Date: Wed, 9 Oct 2024 15:13:48 -0700	[thread overview]
Message-ID: <fe76f462-ef6f-46dd-881a-31d75bdfca5d@linaro.org> (raw)
In-Reply-To: <20240925204845.390689-1-pierrick.bouvier@linaro.org>

On 9/25/24 13:48, Pierrick Bouvier wrote:
> Contrib plugins have been built out of tree so far, thanks to a Makefile.
> However, it is quite inconvenient for maintenance, as we may break them,
> especially for specific architectures.
> 
> First patches are fixing warnings for existing plugins, then we add meson
> support, and finally, we remove Makefile for contrib/plugins.
> 
> Based on the proposal of Anton Kochkov on associated gitlab issue.
> Solves: https://gitlab.com/qemu-project/qemu/-/issues/1710
> 
> Plugins are now deactivated by default on 32-bits hosts (since cf2a78), so we
> can enable with meson without worrying of warnings when building plugins for 32
> bits.
> 
> v2
> --
> 
> - removed warnings fix for 32 bits as they were incorrect. They are not needed
>    anymore as plugins are deprecated for 32 bits hosts.
> 
> Removed patches for individual plugins.
> 
> Pierrick Bouvier (2):
>    meson: build contrib/plugins with meson
>    contrib/plugins: remove Makefile for contrib/plugins
> 
>   configure                   | 18 --------
>   Makefile                    | 10 -----
>   meson.build                 |  4 ++
>   contrib/plugins/Makefile    | 87 -------------------------------------
>   contrib/plugins/meson.build | 23 ++++++++++
>   5 files changed, 27 insertions(+), 115 deletions(-)
>   delete mode 100644 contrib/plugins/Makefile
>   create mode 100644 contrib/plugins/meson.build
> 

Gentle ping on this series, to know if people are interested by this change.

Thanks,
Pierrick


      parent reply	other threads:[~2024-10-09 22:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25 20:48 [PATCH v2 0/2] build contrib/plugins using meson Pierrick Bouvier
2024-09-25 20:48 ` [PATCH v2 1/2] meson: build contrib/plugins with meson Pierrick Bouvier
2024-10-21  9:38   ` Alex Bennée
2024-10-21 15:45     ` Pierrick Bouvier
2024-10-21 15:53     ` Pierrick Bouvier
2024-09-25 20:48 ` [PATCH v2 2/2] contrib/plugins: remove Makefile for contrib/plugins Pierrick Bouvier
2024-10-09 22:13 ` Pierrick Bouvier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe76f462-ef6f-46dd-881a-31d75bdfca5d@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=erdnaxe@crans.org \
    --cc=ma.mandourr@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).