From: Laurent Vivier <lvivier@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] migration: Pass Error ** argument to {save, load}_vmstate
Date: Thu, 11 May 2017 18:34:54 +0200 [thread overview]
Message-ID: <fe7e66f8-7014-9f69-2d1a-2bc4f6e54f50@redhat.com> (raw)
In-Reply-To: <20170511153440.6475-1-quintela@redhat.com>
On 11/05/2017 17:34, Juan Quintela wrote:
> This way we use the "normal" way of printing errors for hmp commands.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>
> ---
>
>
> Add err_report_err() in replay-snapshot.c to really print the error
> messages (dave suggestion)
>
>
> ---
> hmp.c | 9 +++++++--
> include/sysemu/sysemu.h | 4 ++--
> migration/savevm.c | 51 ++++++++++++++++++++++++------------------------
> replay/replay-snapshot.c | 8 ++++++--
> vl.c | 4 +++-
> 5 files changed, 43 insertions(+), 33 deletions(-)
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
next prev parent reply other threads:[~2017-05-11 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 15:34 [Qemu-devel] [PATCH v2] migration: Pass Error ** argument to {save, load}_vmstate Juan Quintela
2017-05-11 16:34 ` Laurent Vivier [this message]
2017-05-12 3:00 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe7e66f8-7014-9f69-2d1a-2bc4f6e54f50@redhat.com \
--to=lvivier@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).