From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE773C433DB for ; Sun, 28 Mar 2021 16:43:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7379B6194A for ; Sun, 28 Mar 2021 16:43:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7379B6194A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQYVP-0006Hw-7j for qemu-devel@archiver.kernel.org; Sun, 28 Mar 2021 12:43:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQYT7-0004vV-EH for qemu-devel@nongnu.org; Sun, 28 Mar 2021 12:40:55 -0400 Received: from mail-oo1-xc2d.google.com ([2607:f8b0:4864:20::c2d]:39775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQYT3-0005MP-QY for qemu-devel@nongnu.org; Sun, 28 Mar 2021 12:40:52 -0400 Received: by mail-oo1-xc2d.google.com with SMTP id r17-20020a4acb110000b02901b657f28cdcso2464907ooq.6 for ; Sun, 28 Mar 2021 09:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=B4bFnk8G06jqiNC5NdshcRb3jT0yWe8TdrUsYes775o=; b=s8LDGSziQUJE+zL2IM54p1opgAt+llujDR3nGtFSiXLSHPbKdcLREilER7c5uD/HU5 aTJ+ctuZvlvxYylWgCKhcN8bIa5mLuw+aROii39IRWF+TojKr3HnOvz8KYPajcyddEhq lbCJs3re09Yusyd8JvO5cd2Z3Q1EFZuOw6vK682f7nKCCFmq0M0WsRHV7BFE4qPfOgvJ uxZP/rJkGlZ9u+F0/ceBnWujuic5gBpauUsAFyggvT8c1JHRsTvoRYGeLquknumV7/5J v1vNdXmVJHZAZssYVC6YDalqFAN4vHwUfs4Vq14O73DFSSqrRWf6MrSdKdhS9vJvdqoI jM9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B4bFnk8G06jqiNC5NdshcRb3jT0yWe8TdrUsYes775o=; b=Ko9yoYSmGnosrctiX+651S316KgY7A3vQfq9ki46ALKpYNqTuVCiD7tmvGHXbZOmuE 2fDJRWd0a/kxN/Js1YpqU7rEDsNld2WUJSdBZPjfJ8gTInnDosGLewkN7UYF08f9fM0S w1basM8T3+up3BXUWCgsztsd5QJy4j1lRP2RmDkZ4BMAc5uzRW/TEKp5/7hFE1/Tl1eI +9RhRy7fDi6wAuyca7GS4IdHgs+IFXKaOhFCg0A8lNLdwomyB0oT3hqLWXtrohXBooiI 0ldnfkRr42DV2c5Mh2szzMJZZ8EcV+qlMrePla1lp0YNgZKyUWmo33wV3CgioAoEZ5fY /vHQ== X-Gm-Message-State: AOAM530rcq4HoKXxmhzgJKCUDmkd6rdU4Bjp+zoorr0JEJxQKrBZJNKa RC/inWDKi5Rje49z1mE0jZV7RA== X-Google-Smtp-Source: ABdhPJzHjUTlIBPhgTCFtS8t1qoXCasAg5jn/QuWAEosDc9QCXW76xAhK4RjDWBMKVVqKoxiOJgPDA== X-Received: by 2002:a4a:c316:: with SMTP id c22mr18844746ooq.65.1616949648499; Sun, 28 Mar 2021 09:40:48 -0700 (PDT) Received: from [192.168.211.34] (171.189-204-159.bestelclientes.com.mx. [189.204.159.171]) by smtp.gmail.com with ESMTPSA id k11sm3890728otp.28.2021.03.28.09.40.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Mar 2021 09:40:48 -0700 (PDT) Subject: Re: [RFC v12 31/65] target/arm: move exception code out of tcg/helper.c To: Claudio Fontana , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210326193701.5981-1-cfontana@suse.de> <20210326193701.5981-32-cfontana@suse.de> From: Richard Henderson Message-ID: Date: Sun, 28 Mar 2021 10:40:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210326193701.5981-32-cfontana@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c2d; envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc2d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Roman Bolshakov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/26/21 1:36 PM, Claudio Fontana wrote: > +#ifdef CONFIG_TCG > + arm_rebuild_hflags(env); > +#endif /* CONFIG_TCG */ No functional changes during code movement. Really. I cannot emphasize this enough. Also, why is this an ifdef and not tcg_enabled()? > + aarch64_restore_sp(env, new_el); > +#ifdef CONFIG_TCG > + arm_rebuild_hflags(env); > +#endif /* CONFIG_TCG */ Likewise. > +#ifdef CONFIG_TCG > + if (tcg_enabled()) { Likewise. And, why in the world do you need both? r~