From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: patches@linaro.org, Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH for-3.1 2/2] hw/block/onenand: use qemu_log_mask() for reporting
Date: Fri, 16 Nov 2018 07:19:10 +0100 [thread overview]
Message-ID: <fe946842-bd54-2db9-c064-44d551c52a2f@redhat.com> (raw)
In-Reply-To: <20181115143535.5885-3-peter.maydell@linaro.org>
On 2018-11-15 15:35, Peter Maydell wrote:
> Update the onenand device to use qemu_log_mask() for reporting
> guest errors and unimplemented features, rather than plain
> fprintf() and hw_error().
>
> (We leave the hw_error() in onenand_reset(), as that is
> triggered by a failure to read the underlying block device
> for the bootRAM, not by guest action.)
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/block/onenand.c | 22 +++++++++++++---------
> 1 file changed, 13 insertions(+), 9 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2018-11-16 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 14:35 [Qemu-devel] [PATCH for-3.1 0/2] hw/block/onenand: fix out-of-bounds read Peter Maydell
2018-11-15 14:35 ` [Qemu-devel] [PATCH for-3.1 1/2] hw/block/onenand: Fix off-by-one error allowing " Peter Maydell
2018-11-15 14:49 ` Philippe Mathieu-Daudé
2018-11-15 16:27 ` Richard Henderson
2018-11-15 14:35 ` [Qemu-devel] [PATCH for-3.1 2/2] hw/block/onenand: use qemu_log_mask() for reporting Peter Maydell
2018-11-15 14:48 ` Philippe Mathieu-Daudé
2018-11-15 16:28 ` Richard Henderson
2018-11-16 6:19 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe946842-bd54-2db9-c064-44d551c52a2f@redhat.com \
--to=thuth@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).