qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	Rayhan Faizel <rayhan.faizel@gmail.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, qemu-arm@nongnu.org
Subject: Re: [PATCH v3 0/3] Add support for I2C in BCM2835 boards
Date: Fri, 23 Feb 2024 07:23:17 +0100	[thread overview]
Message-ID: <fe96d71d-6abc-43f7-9b83-8bec93ab5512@linaro.org> (raw)
In-Reply-To: <CAFEAcA8GFFQ-L6zGcft9q8arJxuggraHYRhcAf4q+Oi+VMSP3Q@mail.gmail.com>

Hi Peter,

On 22/2/24 18:54, Peter Maydell wrote:
> On Tue, 20 Feb 2024 at 13:42, Rayhan Faizel <rayhan.faizel@gmail.com> wrote:
>>
>> This patch series implements support for the Broadcom Serial Controller used
>> by BCM2835 based boards for I2C.


>> Rayhan Faizel (3):
>>    hw/i2c: Implement Broadcom Serial Controller (BSC)
>>    hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2
>>    tests/qtest: Add testcase for BCM2835 BSC
> 
> 
> 
> Applied to target-arm.next, thanks.

Sorry I didn't notice earlier, the I2C[3] IRQ lines have
to be OR-ed using a TYPE_OR_IRQ object before reaching the
INTC. I'd rather a v4, but if you already posted your PR
this can get fixed on top.

Regards,

Phil.


  reply	other threads:[~2024-02-23  6:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-20 13:41 [PATCH v3 0/3] Add support for I2C in BCM2835 boards Rayhan Faizel
2024-02-20 13:41 ` [PATCH v3 1/3] hw/i2c: Implement Broadcom Serial Controller (BSC) Rayhan Faizel
2024-02-23  6:12   ` Philippe Mathieu-Daudé
2024-02-23  6:15   ` Philippe Mathieu-Daudé
2024-02-23 10:05   ` Peter Maydell
2024-02-20 13:41 ` [PATCH v3 2/3] hw/arm: Connect BSC to BCM2835 board as I2C0, I2C1 and I2C2 Rayhan Faizel
2024-02-23  6:20   ` Philippe Mathieu-Daudé
2024-02-20 13:41 ` [PATCH v3 3/3] tests/qtest: Add testcase for BCM2835 BSC Rayhan Faizel
2024-02-23 10:06   ` Peter Maydell
2024-02-22 17:54 ` [PATCH v3 0/3] Add support for I2C in BCM2835 boards Peter Maydell
2024-02-23  6:23   ` Philippe Mathieu-Daudé [this message]
2024-02-23 10:04     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe96d71d-6abc-43f7-9b83-8bec93ab5512@linaro.org \
    --to=philmd@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rayhan.faizel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).