qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
	qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com,
	qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v6 1/8] qcow2: Fix capitalization of header extension constant.
Date: Thu, 11 Jun 2020 16:37:17 -0500	[thread overview]
Message-ID: <feb6213f-d3af-4bf6-f201-af3b45826bb7@redhat.com> (raw)
In-Reply-To: <1591910360-867499-2-git-send-email-andrey.shinkevich@virtuozzo.com>

On 6/11/20 4:19 PM, Andrey Shinkevich wrote:
> Make the capitalization of the hexadecimal numbers consistent for the
> QCOW2 header extension constants in docs/interop/qcow2.txt.
> 
> Suggested-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> ---
>   block/qcow2.c          | 2 +-
>   docs/interop/qcow2.txt | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 

tests/qemu-iotests/114 has an instance that could be adjusted as well 
(no change to 114.out).

With that added,
Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



  reply	other threads:[~2020-06-11 21:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 21:19 [PATCH v6 0/8] iotests: Dump QCOW2 dirty bitmaps metadata Andrey Shinkevich
2020-06-11 21:19 ` [PATCH v6 1/8] qcow2: Fix capitalization of header extension constant Andrey Shinkevich
2020-06-11 21:37   ` Eric Blake [this message]
2020-06-11 21:19 ` [PATCH v6 2/8] qcow2_format.py: make printable data an extension class member Andrey Shinkevich
2020-06-11 21:19 ` [PATCH v6 3/8] qcow2_format.py: Dump bitmap directory info Andrey Shinkevich
2020-06-11 21:19 ` [PATCH v6 4/8] qcow2_format.py: pass cluster size to substructures Andrey Shinkevich
2020-06-11 21:19 ` [PATCH v6 5/8] qcow2_format.py: Dump bitmap table serialized entries Andrey Shinkevich
2020-06-11 21:19 ` [PATCH v6 6/8] qcow2.py: Introduce '-j' key to dump in JSON format Andrey Shinkevich
2020-06-11 21:19 ` [PATCH v6 7/8] qcow2_format.py: collect fields " Andrey Shinkevich
2020-06-11 21:19 ` [PATCH v6 8/8] qcow2_format.py: support dumping metadata " Andrey Shinkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=feb6213f-d3af-4bf6-f201-af3b45826bb7@redhat.com \
    --to=eblake@redhat.com \
    --cc=andrey.shinkevich@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).