From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F38C433FF for ; Wed, 7 Aug 2019 15:49:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E588722297 for ; Wed, 7 Aug 2019 15:49:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RVLg7BWv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E588722297 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvOCI-0000HD-8T for qemu-devel@archiver.kernel.org; Wed, 07 Aug 2019 11:49:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58897) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvOAV-0005mp-2B for qemu-devel@nongnu.org; Wed, 07 Aug 2019 11:48:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvOAU-0007wE-1R for qemu-devel@nongnu.org; Wed, 07 Aug 2019 11:48:02 -0400 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:36077) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvOAT-0007vA-QW for qemu-devel@nongnu.org; Wed, 07 Aug 2019 11:48:01 -0400 Received: by mail-pl1-x642.google.com with SMTP id k8so41432246plt.3 for ; Wed, 07 Aug 2019 08:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VDEsVbbZnitZv/zjndZKRIe4vwOmbwYZIOsMpNk3ebQ=; b=RVLg7BWv3CBJVe/avUoZpspK3GJNIJez1Z7w54GHlzZZOmRSlrkq/tPS2PNChBVLr8 8pjmcInx1bE7xvrAEp6rua26vBSKahPj07l/M3gEk7Zz8G6naD9CYzr8MTTPaLI2awUr djak9esVAfjo8Wo1CvikhrDoypacMR0MwiNSDckmKpiQRnxXqRehZgpzONjiT05hUox3 BuCUI/nMdt1d9U4kCpWnMkHG94zlXmngtUNmPasvKOFudsVEh4gDlM4y2AF84Xtx612H 5+pQz31asGe+NRyn7AIyc36mAbRO4Q1W16i4pFdAEGekwTm4skbMmxer2GRt0xQGGUfY SADQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VDEsVbbZnitZv/zjndZKRIe4vwOmbwYZIOsMpNk3ebQ=; b=ojciEk2I0uf53cviIgSrCP01amLbUh1VACjlET43wdYVt7DG4XvJs4tT9Fzq+uVg7D FOm8pdGUn05svi56m04KLz0OrIlpxWccrGllfiJ1ZWUWKfSWSPCUsQSGOQtVu2BEYv0x OTzMenE20ztznd5eUMUB9b4ZRsEvYwz59N11D4SChR1Q45D9ABHBOrLGfNoa0Z7Cl6Qa EgQeBle1P2YNn1C2WpnggsIXTt+EvYxM/pMJJ5Bcch9gEefbzySA9V4eWyMeOdULbArN m07xLGMSI+X0Km9MowtcfKVqPidYoE4Ur5iyYV37dx5KzqQ9DgEvQ50c2YLw/I0budYw o6Dg== X-Gm-Message-State: APjAAAUBa4CeCGmxBguse9T1f2rqpmdfqzAl8dyBuX2jZRbGt2TMJLD7 ifEtH6RjOG9dcFSf/RDp4FNl6w== X-Google-Smtp-Source: APXvYqybocu4flPeVmJWnkfdg+h4qK9Xs4NK5mlXbh8VvAvaeF0v60yuh9bLWnxQJYUgpDIh08u1Ow== X-Received: by 2002:aa7:8383:: with SMTP id u3mr9983779pfm.175.1565192880884; Wed, 07 Aug 2019 08:48:00 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id a6sm91814707pfa.162.2019.08.07.08.47.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Aug 2019 08:47:59 -0700 (PDT) To: tony.nguyen@bt.com, qemu-devel@nongnu.org References: <45ec4924e0b34a3d9124e2db06af75b4@tpw09926dag18e.domain1.systemhost.net> <1565166627824.57868@bt.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Wed, 7 Aug 2019 08:47:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1565166627824.57868@bt.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::642 Subject: Re: [Qemu-devel] [PATCH v6 13/26] target/mips: Hard code size with MO_{8|16|32|64} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, peter.maydell@linaro.org, walling@linux.ibm.com, dmitry.fleytman@gmail.com, imammedo@redhat.com, sagark@eecs.berkeley.edu, david@redhat.com, jasowang@redhat.com, palmer@sifive.com, mark.cave-ayland@ilande.co.uk, laurent@vivier.eu, keith.busch@intel.com, jcmvbkbc@gmail.com, frederic.konrad@adacore.com, pbonzini@redhat.com, kraxel@redhat.com, edgar.iglesias@gmail.com, gxt@mprc.pku.edu.cn, pburton@wavecomp.com, marex@denx.de, robh@kernel.org, hare@suse.com, sstabellini@kernel.org, berto@igalia.com, proljc@gmail.com, qemu-block@nongnu.org, arikalo@wavecomp.com, jslaby@suse.cz, deller@gmx.de, mst@redhat.com, magnus.damm@gmail.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, mreitz@redhat.com, hpoussin@reactos.org, joel@jms.id.au, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, rth@twiddle.net, philmd@redhat.com, green@moxielogic.com, atar4qemu@gmail.com, antonynpavlov@gmail.com, jiri@resnulli.us, ehabkost@redhat.com, minyard@acm.org, sw@weilnetz.de, alistair@alistair23.me, chouteau@adacore.com, b.galvani@gmail.com, eric.auger@redhat.com, qemu-s390x@nongnu.org, qemu-arm@nongnu.org, peter.chubb@nicta.com.au, yuval.shaia@oracle.com, stefanha@redhat.com, marcandre.lureau@redhat.com, shorne@gmail.com, sundeep.lkml@gmail.com, jsnow@redhat.com, david@gibson.dropbear.id.au, kwolf@redhat.com, crwulff@gmail.com, qemu-riscv@nongnu.org, xiaoguangrong.eric@gmail.com, i.mitsyanko@gmail.com, lersek@redhat.com, cohuck@redhat.com, alex.williamson@redhat.com, Andrew.Baumann@microsoft.com, jcd@tribudubois.net, andrew@aj.id.au, michael@walle.cc, paul.durrant@citrix.com, qemu-ppc@nongnu.org, huth@tuxfamily.org, amarkovic@wavecomp.com, kbastian@mail.uni-paderborn.de, jan.kiszka@web.de, stefanb@linux.ibm.com, andrew.smirnov@gmail.com, aurelien@aurel32.net, clg@kaod.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/7/19 1:30 AM, tony.nguyen@bt.com wrote: > Temporarily no-op size_memop was introduced to aid the conversion of > memory_region_dispatch_{read|write} operand "unsigned size" into > "MemOp op". > > Now size_memop is implemented, again hard coded size but with > MO_{8|16|32|64}. This is more expressive and avoid size_memop calls. > > Signed-off-by: Tony Nguyen > --- > target/mips/op_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~