From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, eblake@redhat.com,
jsnow@redhat.com, famz@redhat.com, den@openvz.org,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v16 08/22] qcow2: add bitmaps extension
Date: Mon, 27 Feb 2017 13:27:13 +0100 [thread overview]
Message-ID: <fec4aa12-6aaa-5e4e-3439-01578db31327@redhat.com> (raw)
In-Reply-To: <20170225170758.427066-9-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
On 25.02.2017 18:07, Vladimir Sementsov-Ogievskiy wrote:
> Add bitmap extension as specified in docs/specs/qcow2.txt.
> For now, just mirror extension header into Qcow2 state and check
> constraints. Also, calculate refcounts for qcow2 bitmaps, to not break
> qemu-img check.
>
> For now, disable image resize if it has bitmaps. It will be fixed later.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/Makefile.objs | 2 +-
> block/qcow2-bitmap.c | 439 +++++++++++++++++++++++++++++++++++++++++++++++++
> block/qcow2-refcount.c | 6 +
> block/qcow2.c | 124 +++++++++++++-
> block/qcow2.h | 27 +++
> 5 files changed, 592 insertions(+), 6 deletions(-)
> create mode 100644 block/qcow2-bitmap.c
Somehow I have the feeling Kevin will find bad things in this patch, but
since I have already approved of all of the previous patches this one is
composed of and the changes on top of that look OK to me:
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2017-02-27 12:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 17:07 [Qemu-devel] [PATCH v16 00/22] qcow2: persistent dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 01/22] specs/qcow2: fix bitmap granularity qemu-specific note Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 02/22] specs/qcow2: do not use wording 'bitmap header' Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 03/22] hbitmap: improve dirty iter Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 04/22] tests: add hbitmap iter test Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 05/22] block: fix bdrv_dirty_bitmap_granularity signature Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 06/22] block/dirty-bitmap: add deserialize_ones func Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 07/22] qcow2-refcount: rename inc_refcounts() and make it public Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 08/22] qcow2: add bitmaps extension Vladimir Sementsov-Ogievskiy
2017-02-27 12:27 ` Max Reitz [this message]
2017-02-27 23:09 ` John Snow
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 09/22] qcow2: autoloading dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-02-27 12:50 ` Max Reitz
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 10/22] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 11/22] block: introduce persistent dirty bitmaps Vladimir Sementsov-Ogievskiy
2017-02-27 13:38 ` Max Reitz
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 12/22] block/dirty-bitmap: add bdrv_dirty_bitmap_next() Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 13/22] qcow2: add persistent dirty bitmaps support Vladimir Sementsov-Ogievskiy
2017-02-27 14:38 ` Max Reitz
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 14/22] block: add bdrv_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 15/22] qcow2: add .bdrv_can_store_new_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-02-27 14:46 ` Max Reitz
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 16/22] qmp: add persistent flag to block-dirty-bitmap-add Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 17/22] qmp: add autoload parameter " Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 18/22] qmp: add x-debug-block-dirty-bitmap-sha256 Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 19/22] iotests: test qcow2 persistent dirty bitmap Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 20/22] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 21/22] qcow2: add .bdrv_remove_persistent_dirty_bitmap Vladimir Sementsov-Ogievskiy
2017-02-25 17:07 ` [Qemu-devel] [PATCH v16 22/22] qmp: block-dirty-bitmap-remove: remove persistent Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fec4aa12-6aaa-5e4e-3439-01578db31327@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).