From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v5 11/11] nbd-server: Allow node name for nbd-server-add
Date: Wed, 3 Aug 2016 18:36:25 +0200 [thread overview]
Message-ID: <fecbc8ff-cbf6-b480-0899-d9554e8da00f@redhat.com> (raw)
In-Reply-To: <1470223294-3870-12-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On 03.08.2016 13:21, Kevin Wolf wrote:
> There is no reason why an NBD server couldn't be started for any node,
> even if it's not on the top level. This converts nbd-server-add to
> accept a node-name.
>
> Note that there is a semantic difference between using a BlockBackend
> name and the node name of its root: In the former case, the NBD server
> is closed on eject; in the latter case, the NBD server doesn't drop its
> reference and keeps the image file open this way.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> blockdev-nbd.c | 21 +++++++++------------
> qapi/block.json | 4 ++--
> 2 files changed, 11 insertions(+), 14 deletions(-)
As per the terms of surrender as stated on IRC:
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 498 bytes --]
next prev parent reply other threads:[~2016-08-03 16:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 11:21 [Qemu-devel] [PATCH v5 00/11] block: Accept node-name in all node level QMP commands Kevin Wolf
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 01/11] block: Accept node-name for block-stream Kevin Wolf
2016-08-03 12:25 ` Alberto Garcia
2016-08-03 12:53 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 02/11] block: Accept node-name for block-commit Kevin Wolf
2016-08-03 12:32 ` Alberto Garcia
2016-08-03 12:54 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 03/11] block: Accept node-name for blockdev-backup Kevin Wolf
2016-08-03 12:58 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 04/11] block: Accept node-name for blockdev-mirror Kevin Wolf
2016-08-03 14:59 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync Kevin Wolf
2016-08-03 15:06 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 06/11] block: Accept node-name for blockdev-snapshot-internal-sync Kevin Wolf
2016-08-03 15:07 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 07/11] block: Accept node-name for change-backing-file Kevin Wolf
2016-08-03 15:09 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 08/11] block: Accept node-name for drive-backup Kevin Wolf
2016-08-03 15:14 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 09/11] block: Accept node-name for drive-mirror Kevin Wolf
2016-08-03 15:32 ` Max Reitz
2016-08-03 15:34 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 10/11] nbd-server: Use a separate BlockBackend Kevin Wolf
2016-08-03 16:00 ` Max Reitz
2016-08-03 11:21 ` [Qemu-devel] [PATCH v5 11/11] nbd-server: Allow node name for nbd-server-add Kevin Wolf
2016-08-03 16:12 ` Max Reitz
2016-08-03 16:36 ` Max Reitz [this message]
2016-08-08 13:14 ` [Qemu-devel] [PATCH v5 00/11] block: Accept node-name in all node level QMP commands Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fecbc8ff-cbf6-b480-0899-d9554e8da00f@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).