From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUz9m-0001Oy-K5 for qemu-devel@nongnu.org; Wed, 03 Aug 2016 12:36:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUz9k-0002aQ-Up for qemu-devel@nongnu.org; Wed, 03 Aug 2016 12:36:33 -0400 References: <1470223294-3870-1-git-send-email-kwolf@redhat.com> <1470223294-3870-12-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: Date: Wed, 3 Aug 2016 18:36:25 +0200 MIME-Version: 1.0 In-Reply-To: <1470223294-3870-12-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Wdb5vlFV11NLXPOBWl9M5Ci6fPJbaaSSf" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v5 11/11] nbd-server: Allow node name for nbd-server-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Wdb5vlFV11NLXPOBWl9M5Ci6fPJbaaSSf From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org Message-ID: Subject: Re: [Qemu-block] [PATCH v5 11/11] nbd-server: Allow node name for nbd-server-add References: <1470223294-3870-1-git-send-email-kwolf@redhat.com> <1470223294-3870-12-git-send-email-kwolf@redhat.com> In-Reply-To: <1470223294-3870-12-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 03.08.2016 13:21, Kevin Wolf wrote: > There is no reason why an NBD server couldn't be started for any node, > even if it's not on the top level. This converts nbd-server-add to > accept a node-name. >=20 > Note that there is a semantic difference between using a BlockBackend > name and the node name of its root: In the former case, the NBD server > is closed on eject; in the latter case, the NBD server doesn't drop its= > reference and keeps the image file open this way. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev-nbd.c | 21 +++++++++------------ > qapi/block.json | 4 ++-- > 2 files changed, 11 insertions(+), 14 deletions(-) As per the terms of surrender as stated on IRC: Reviewed-by: Max Reitz --Wdb5vlFV11NLXPOBWl9M5Ci6fPJbaaSSf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEvBAEBCAAZBQJXoh2JEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRA7sUIC6DisrWTB CACOYs2Rb+06sWWi82ovZW8c5RXngIgQVXhQf4pwYKhBAHLXU6kOAVbo9smP8kDF ryC+jtREga+NNALWO46eASqvNi9bHxg3KtRVCfxQst4OOXWQBuA4rIjRmJpktUqe wfNcrj+Ba3Ihz6cIw52X2WEtX1ySU3D/Otdr0iv68wARl5fCV7Kh6KhbmRsiYPYo QNpvAAuVvRRMabvrBXRbgXHmaj8NnF/cMGwgtoULwAOewoEFwEJKybUqlP7Fyn1/ d0/vgNXAqya2/xNGoBnQ0b0CSYDFrBr6Rn1d+W6d0NEfmva9ewlNJ33FRhOniNfG jtjzvRfMcP9RfROTAC5yY/su =MNvR -----END PGP SIGNATURE----- --Wdb5vlFV11NLXPOBWl9M5Ci6fPJbaaSSf--