qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, peter.maydell@linaro.org
Subject: Re: [PATCH] RFC: replace qemu_real_host_page variables with inlined functions
Date: Mon, 7 Mar 2022 07:41:24 -1000	[thread overview]
Message-ID: <fedbc4bc-c5de-4320-4103-f46730680dbe@linaro.org> (raw)
In-Reply-To: <20220301144611.1299277-1-marcandre.lureau@redhat.com>

On 3/1/22 04:46, marcandre.lureau@redhat.com wrote:
> Replace the global variables with inlined helper functions. getpagesize() is very
> likely annotated with a "const" function attribute (at least with glibc), and thus
> optimization should apply even better.
> 
> This avoids the need for a constructor initialization too.

What's the change in the size of the qemu text section with this change?


r~


  parent reply	other threads:[~2022-03-07 17:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01 14:46 [PATCH] RFC: replace qemu_real_host_page variables with inlined functions marcandre.lureau
2022-03-07 11:52 ` Marc-André Lureau
2022-03-07 17:41 ` Richard Henderson [this message]
2022-03-08 11:34   ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fedbc4bc-c5de-4320-4103-f46730680dbe@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).