From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40654 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q1erf-0005AO-W7 for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:09:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q1ere-0007Pr-GF for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:09:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q1ere-0007Ph-4t for qemu-devel@nongnu.org; Mon, 21 Mar 2011 09:09:42 -0400 From: Amit Shah Date: Mon, 21 Mar 2011 18:39:20 +0530 Message-Id: In-Reply-To: References: In-Reply-To: References: Subject: [Qemu-devel] [PATCH 5/7] virtio-serial: Don't clear ->have_data() pointer after unplug List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amit Shah , qemu list After a port unplug operation, the port->info->have_data() pointer was set to NULL. The problem is, the ->info struct is shared by all ports, effectively disabling writes to other ports. Reported-by: juzhang Signed-off-by: Amit Shah --- hw/virtio-console.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 4440784..be59558 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -82,7 +82,6 @@ static int virtconsole_exitfn(VirtIOSerialPort *port) VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port); if (vcon->chr) { - port->info->have_data = NULL; qemu_chr_close(vcon->chr); } -- 1.7.4