Re: [Qemu-devel] [Issues] PCI hotplug does not work well on pc platform?

[Marcel Apfelbaum <marcel.apfelbaum@gmail.com>]

On 2/14/19 4:15 PM, Igor Mammedov wrote:
> On Thu, 14 Feb 2019 15:12:35 +0200
> Marcel Apfelbaum <marcel.apfelbaum@gmail.com> wrote:
>
>> Hi Igor, Jing
>>
>> On 2/14/19 1:31 PM, Igor Mammedov wrote:
>>> On Wed, 13 Feb 2019 15:40:57 +0800
>>> "Liu, Jing2" <jing2.liu@linux.intel.com> wrote:
>>>   
>>>> Hi Igor,
>>>>
>>>> Thanks for your reply!
>>>>
>>>> On 2/5/2019 11:47 PM, Igor Mammedov wrote:
>>>>> On Wed, 30 Jan 2019 21:02:10 +0800
>>>>> "Liu, Jing2" <jing2.liu@linux.intel.com> wrote:
>>>>>       
>>>>>> Hi everyone,
>>>>>>
>>>>>> I have two questions.
>>>>>> 1. PCI hotplug on pci.0 must manually rescan in guest. The ACPI hotplug
>>>>>> handler sends the GPE event to guest but it seems guest doesn't receive
>>>>>> it? I tried to open ACPI debug level/layer to 0xffffffff, in order to
>>>>>> see if there is any message after device_add in monitor, but no message
>>>>>> comes out until I manually rescan. Also tried printk in
>>>>>> acpi_ev_gpe_xrupt_handler() and acpi_ev_sci_xrupt_handler(). No output
>>>>>> in dmesg.
>>>>>> (I'm sure that CONFIG_HOTPLUG_PCI_PCIE=y, CONFIG_HOTPLUG_PCI_CPCI=y,
>>>>>> CONFIG_HOTPLUG_PCI=y, CONFIG_HOTPLUG_PCI_ACPI=y)
>> What about |CONFIG_HOTPLUG_PCI_SHPC=y ?
>>
>> |
>>>>>> Whether this is a kind of design or a known issue? Does guest receive
>>>>>> the request, where can I find the
>>>>> does it work with known to work kernels (RHEL7)?
>>>>>
>>>>> Also sharing used QEMU version and command line could help.
>>>>>       
>>>> Is there any key config of kernel in guest, besides those I listed above?
>>> Maybe Marcel knows something about it
>>> (CCed)
>> May I ask why do you need SHPC hotplug and not the ACPI based hotplug?
> I'd say SHPC one is preferred one, ACPI hotplug is rather complicated
> QEMU hack to make legacy Windows guest support hotplug of PCI devices.

I can understand and agree, but is much less tested; anyway I distinctly
remember I fix all the problems with PCI SHPC hotplug, it should work.

Thanks,
Marcel

>   
> [...]