From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 3/4] hw/i386: Add 'vmport.h' local header
Date: Mon, 4 May 2020 10:25:29 -0700 [thread overview]
Message-ID: <ff00827f-d553-d5f1-1c9d-f135e1999bc5@linaro.org> (raw)
In-Reply-To: <20200504083342.24273-4-f4bug@amsat.org>
On 5/4/20 1:33 AM, Philippe Mathieu-Daudé wrote:
> Move 'vmport' related declarations in a target-specific header.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/i386/vmport.h | 34 ++++++++++++++++++++++++++++++++++
> include/hw/i386/pc.h | 3 ---
> hw/i386/pc.c | 1 +
> hw/i386/vmmouse.c | 1 +
> hw/i386/vmport.c | 1 +
> 5 files changed, 37 insertions(+), 3 deletions(-)
> create mode 100644 hw/i386/vmport.h
> +typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
Maybe get rid of the useless parenthesis here.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-05-04 17:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 8:33 [PATCH 0/4] hw/i386: Restrict vmport/vmmouse devices to x86 targets Philippe Mathieu-Daudé
2020-05-04 8:33 ` [PATCH 1/4] hw/i386/pc: Create 'vmport' device in place Philippe Mathieu-Daudé
2020-05-04 17:23 ` Richard Henderson
2020-05-04 8:33 ` [PATCH 2/4] hw/i386/vmport: Remove unused 'hw/input/i8042.h' include Philippe Mathieu-Daudé
2020-05-04 17:23 ` Richard Henderson
2020-05-04 8:33 ` [PATCH 3/4] hw/i386: Add 'vmport.h' local header Philippe Mathieu-Daudé
2020-05-04 17:25 ` Richard Henderson [this message]
2020-05-04 8:33 ` [PATCH 4/4] hw/i386: Make vmmouse helpers static Philippe Mathieu-Daudé
2020-05-04 17:29 ` Richard Henderson
2020-05-05 5:36 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff00827f-d553-d5f1-1c9d-f135e1999bc5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).