From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: deller@gmx.de, svens@stackframe.org
Subject: Re: [PATCH 2/2] target/hppa: Fix B,GATE for wide mode
Date: Thu, 21 Mar 2024 20:34:13 +0100 [thread overview]
Message-ID: <ff49230b-0ab0-4a40-b499-4f072d883f75@linaro.org> (raw)
In-Reply-To: <20240321192813.371526-3-richard.henderson@linaro.org>
On 21/3/24 20:28, Richard Henderson wrote:
> Do not clobber the high bits of the address by using a 32-bit deposit.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/hppa/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index 1766a63001..f875d76a23 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -3880,7 +3880,7 @@ static bool trans_b_gate(DisasContext *ctx, arg_b_gate *a)
> }
> /* No change for non-gateway pages or for priv decrease. */
> if (type >= 4 && type - 4 < ctx->privilege) {
> - dest = deposit32(dest, 0, 2, type - 4);
> + dest = deposit64(dest, 0, 2, type - 4);
> }
> } else {
> dest &= -4; /* priv = 0 */
Fixes: 43e056522f ("target/hppa: Implement B,GATE insn")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-03-21 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 19:28 [PATCH for-9.0 0/2] target/hppa: two more simple fixes Richard Henderson
2024-03-21 19:28 ` [PATCH 1/2] target/hppa: Fix BE,L set of sr0 Richard Henderson
2024-03-21 19:28 ` [PATCH 2/2] target/hppa: Fix B,GATE for wide mode Richard Henderson
2024-03-21 19:34 ` Philippe Mathieu-Daudé [this message]
2024-03-21 20:05 ` Richard Henderson
2024-03-22 6:57 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff49230b-0ab0-4a40-b499-4f072d883f75@linaro.org \
--to=philmd@linaro.org \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).